Mailing-List: contact dev-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Content-Type: text/plain; charset=us-ascii
Subject: Re: [VOTE] Release Apache Groovy 2.4.6
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
From: Graeme Rocher <graeme.rocher@gmail.com>
In-Reply-To: 
 <CAMbkE7TnX+mJQ+4=hz+ypjQn7nkBA-t0Vba7AesOmaU5bycMpA@mail.gmail.com>
Date: Mon, 22 Feb 2016 09:40:30 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <6DEB37B8-66C4-4890-A74C-32A3140CF511@gmail.com>
References: 
 <CADQzvm=P6VUAvKWzx8NuWTZJ4rUfBBDzGdTVAA1HbTD-Mekh3A@mail.gmail.com>
 <20160219074917.GA21948@tpx> <56C9ACC1.4010203@gmx.net>
 <CAMbkE7TnX+mJQ+4=hz+ypjQn7nkBA-t0Vba7AesOmaU5bycMpA@mail.gmail.com>
To: dev@groovy.apache.org,
 paulk@asert.com.au

Bit late, but +1 from me too.

Graeme

> On 22 Feb 2016, at 07:37, Paul King <paulk@asert.com.au> wrote:
>=20
> +1
>=20
> On Sun, Feb 21, 2016 at 10:25 PM, Pascal Schumacher
> <pascalschumacher@gmx.net> wrote:
>> Hi Konstantin,
>>=20
>> thanks for the in-depth check. :)
>>=20
>> Am 19.02.2016 um 08:49 schrieb Konstantin Boudnik:
>>>=20
>>> - gradle.properties is missing the ASL header and breaking the rat =
check.
>>> I
>>>   figure this alone doesn't warrant a respin, but the header needs =
to be
>>> added
>>>   or the file needs to be excluded from the check
>>=20
>> in the git repo this file has a header, but it's modified by teamcity =
when
>> it builds a release and this modification remove the comments. If =
it's o.k.
>> to exclude such a file from the rat check, we can add an exclude.
>>>=20
>>> - build is generating the binaries
>>>   - tests complete ok (wow, 8k+ tests, impressive!)
>>>   - 2 failures:  JsonBuilderTest.testJsonBuilder,
>>> StreamingJsonBuilderTest.testStreamingJsonBuilder
>>=20
>> Do you still have the stacktrace of the failure. Maybe we can make =
these
>> test more robust.
>>=20
>> Cheers,
>> Pascal