groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From C├ędric Champeau <cedric.champ...@gmail.com>
Subject Re: [GitHub] groovy pull request: Link to MrHaki's blog in TupleConstructor jav...
Date Wed, 24 Feb 2016 16:30:21 GMT
I don't think linking to external resources like this is a good idea. We
don't own the end link, it can be dead very easily, especially in the
future. I would rather improve the documentation.

2016-02-24 17:25 GMT+01:00 pledbrook <git@git.apache.org>:

> GitHub user pledbrook opened a pull request:
>
>     https://github.com/apache/groovy/pull/271
>
>     Link to MrHaki's blog in TupleConstructor javadoc.
>
>     As discussed on Twitter, here's an example of linking to @mrhaki's
> blog from the javadocs so that people have ready access to more examples
> for certain classes. If this gets merged, I'll look into adding more.
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/pledbrook/incubator-groovy patch-01
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/groovy/pull/271.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
>     This closes #271
>
> ----
> commit 6741ce458c01cf8ab5df770a284d53a3657dd389
> Author: Peter Ledbrook <peter@cacoethes.co.uk>
> Date:   2016-02-24T16:23:07Z
>
>     Link to MrHaki's blog in TupleConstructor javadoc.
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

Mime
View raw message