groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Russel Winder <rus...@winder.org.uk>
Subject Re: GROOVY-7378: Support JAVA_OPTS containing quoted arguments on *nix
Date Fri, 15 Jan 2016 19:26:41 GMT
On Fri, 2016-01-15 at 18:53 +0100, Pascal Schumacher wrote:
> Hello everybody,
> 
> is there anybody with unix shell scripting know-how who would be so
> kind 
> to take a look at the pull request: 
> https://github.com/apache/groovy/pull/5 for 
> https://issues.apache.org/jira/browse/GROOVY-7378 and offer some 
> feedback as to whether it should be merged?

This looks very dubious to me: seeing eval exec is a bit of a code
smell.

I have commented on the PR.


-- 
Russel.
=============================================================================
Dr Russel Winder      t: +44 20 7585 2200   voip: sip:russel.winder@ekiga.net
41 Buckmaster Road    m: +44 7770 465 077   xmpp: russel@winder.org.uk
London SW11 1EN, UK   w: www.russel.org.uk  skype: russel_winder


Mime
View raw message