groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From John Wagenleitner <john.wagenleit...@gmail.com>
Subject Re: Cleanup and internal package names
Date Wed, 11 Nov 2015 19:52:01 GMT
On Wed, Nov 11, 2015 at 11:30 AM, Guillaume Laforge <glaforge@gmail.com>
wrote:

> And I imagine all the tests are still fine without those internal public
> methods removed?
>
>
Hi Guillaume,

Yes, a './gradlew clean test' passes both with and without the 8 unused
methods.



> On Wed, Nov 11, 2015 at 7:34 PM, John Wagenleitner <
> john.wagenleitner@gmail.com> wrote:
>
>> I was recently looking into a few JSON related issues
>> (GROOVY-6813/6922/7665) and came across a number of unused methods in the
>> class groovy.json.internal.CharScanner.  Before I did anything I thought
>> I'd better check and see if the project team is open to "cleanup" pull
>> requests (not associated with any particular issue).
>>
>> I know that the stability of the public API is extremely important and
>> this class and it's methods are public, but not used outside its module in
>> the groovy codebase.  Is being in a package named "internal" (nested within
>> a public package groovy.json) sufficient to allow removing unused public
>> methods and/or changing their signatures?
>>
>> John
>>
>
>
>
> --
> Guillaume Laforge
> Apache Groovy committer & PMC member
> Product Ninja & Advocate at Restlet <http://restlet.com>
>
> Blog: http://glaforge.appspot.com/
> Social: @glaforge <http://twitter.com/glaforge> / Google+
> <https://plus.google.com/u/0/114130972232398734985/posts>
>

Mime
View raw message