groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cédric Champeau <cedric.champ...@gmail.com>
Subject Re: Re: [incubator-groovy] remove duplicated method visitBlockStatement added in 9436c55fc5a14a20bc503c46c9a837753c846ff6 (5771929)
Date Mon, 12 Oct 2015 07:12:27 GMT
FWIW, it doesn't break binary compatibility, because the method is defined
in the super class. However I have no pb with reintroducing.

2015-10-12 9:03 GMT+02:00 Pascal Schumacher <pascalschumacher@gmx.net>:

> I was surprised that Cédric removed a public method from ClassCodeVisitorSupport
> with
> https://github.com/apache/incubator-groovy/commit/248e0fd9530573d234212d7b3627e3d42168fde4,
> because he is a big proponent of maintaining binary compatibility.
>
> -------- Weitergeleitete Nachricht -------- Betreff: Re:
> [incubator-groovy] remove duplicated method visitBlockStatement added in
> 9436c55fc5a14a20bc503c46c9a837753c846ff6 (5771929) Datum: Sun, 11 Oct
> 2015 15:53:42 -0700 Von: Paul King <notifications@github.com>
> <notifications@github.com> Antwort an: apache/incubator-groovy
> <reply+00294f2d644f99731c2a962218e4120866bfc875c1257e3f92cf000000011232aa7692a163ce00d12855@reply.github.com>
> <reply+00294f2d644f99731c2a962218e4120866bfc875c1257e3f92cf000000011232aa7692a163ce00d12855@reply.github.com>
An:
> apache/incubator-groovy <incubator-groovy@noreply.github.com>
> <incubator-groovy@noreply.github.com> Kopie (CC): Pascal Schumacher
> <pascalschumacher@gmx.net> <pascalschumacher@gmx.net>
>
> Yes, this was removed as part of the MacroGroovy PR (which isn't part of
> GROOVY_2_4_X). I had to put it back in for master to make the
> LineColumnChecks work. We'll have to keep an eye out as to whether it
> affects MacroGroovy or was just removed because it didn't seem to be
> necessary during MacroGroovy rejigging.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-groovy/commit/57719291957e34c409552412304f4c6268ff1735#commitcomment-13707349>
> .
>
>
>

Mime
View raw message