Mailing-List: contact dev-help@groovy.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <55EE8FB1.3060001@gmx.org>
References: 
 <CADQzvm=vCHR7c1-uaCMkEq7i58ofvvaUrnqHjiGxMp0YQFuc5w@mail.gmail.com>
	<55EE8FB1.3060001@gmx.org>
Date: Tue, 8 Sep 2015 09:52:04 +0200
Message-ID: 
 <CAJ2HCd9jH=Gs=iZNVcJPwYORtK+u_hWoRJ0fuXFFJBgbEH=A2Q@mail.gmail.com>
Subject: Re: Rolling back change to use ClassValue
From: Guillaume Laforge <glaforge@gmail.com>
To: dev@groovy.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a1134fe14559de3051f37a4c6

--001a1134fe14559de3051f37a4c6
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Or perhaps a kind of feature toggle, with an environment variable?
We use the former mechanism by default, unless this env var is set to true?
That way we can still easily check if the VM bug / behavior is fixed /
changed?

On Tue, Sep 8, 2015 at 9:35 AM, Jochen Theodorou <blackdrag@gmx.org> wrote:

> Am 08.09.2015 09:07, schrieb C=C3=A9dric Champeau:
>
>> Hi guys,
>>
>> As some of you may know, I've been investigating a memory leak which
>> involves all versions of Groovy starting from 2.4. The leak comes from a
>> bug in the VM regarding how it handles ClassValue, that Groovy 2.4
>> started using. All VMs are affected (7, 8 and 9) and it's still unclear
>> when this will be fixed. So I would like to suggest to rollback this
>> change for the next release.
>>
>> Basically, this commit:
>>
>> https://github.com/apache/incubator-groovy/commit/97d78e9e52deb52c8e66db=
501ef208f30384d014
>>
>> It greatly affects Gradle, so I would suggest to make the change ASAP
>> (2.4.5) if everyone agrees.
>>
>
> -1
>
> We can disable it by default till we find a better solution. But we don't
> need to roll it back completely. I am afraid of the fix not being
> applicable later on anymore
>
> bye blackdrag
>
> --
> Jochen "blackdrag" Theodorou
> blog: http://blackdragsview.blogspot.com/
>
>


--=20
Guillaume Laforge
Apache Groovy committer & PMC member
Product Ninja & Advocate at Restlet <http://restlet.com>

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

--001a1134fe14559de3051f37a4c6
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Or perhaps a kind of feature toggle, with an environment v=
ariable?<div>We use the former mechanism by default, unless this env var is=
 set to true?</div><div>That way we can still easily check if the VM bug / =
behavior is fixed / changed?</div></div><div class=3D"gmail_extra"><br><div=
 class=3D"gmail_quote">On Tue, Sep 8, 2015 at 9:35 AM, Jochen Theodorou <sp=
an dir=3D"ltr">&lt;<a href=3D"mailto:blackdrag@gmx.org" target=3D"_blank">b=
lackdrag@gmx.org</a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote"=
 style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><d=
iv class=3D"HOEnZb"><div class=3D"h5">Am <a href=3D"tel:08.09.2015%2009" va=
lue=3D"+33809201509" target=3D"_blank">08.09.2015 09</a>:07, schrieb C=C3=
=A9dric Champeau:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Hi guys,<br>
<br>
As some of you may know, I&#39;ve been investigating a memory leak which<br=
>
involves all versions of Groovy starting from 2.4. The leak comes from a<br=
>
bug in the VM regarding how it handles ClassValue, that Groovy 2.4<br>
started using. All VMs are affected (7, 8 and 9) and it&#39;s still unclear=
<br>
when this will be fixed. So I would like to suggest to rollback this<br>
change for the next release.<br>
<br>
Basically, this commit:<br>
<a href=3D"https://github.com/apache/incubator-groovy/commit/97d78e9e52deb5=
2c8e66db501ef208f30384d014" rel=3D"noreferrer" target=3D"_blank">https://gi=
thub.com/apache/incubator-groovy/commit/97d78e9e52deb52c8e66db501ef208f3038=
4d014</a><br>
<br>
It greatly affects Gradle, so I would suggest to make the change ASAP<br>
(2.4.5) if everyone agrees.<br>
</blockquote>
<br></div></div>
-1<br>
<br>
We can disable it by default till we find a better solution. But we don&#39=
;t need to roll it back completely. I am afraid of the fix not being applic=
able later on anymore<br>
<br>
bye blackdrag<span class=3D"HOEnZb"><font color=3D"#888888"><br>
<br>
-- <br>
Jochen &quot;blackdrag&quot; Theodorou<br>
blog: <a href=3D"http://blackdragsview.blogspot.com/" rel=3D"noreferrer" ta=
rget=3D"_blank">http://blackdragsview.blogspot.com/</a><br>
<br>
</font></span></blockquote></div><br><br clear=3D"all"><div><br></div>-- <b=
r><div class=3D"gmail_signature"><div dir=3D"ltr"><div><div dir=3D"ltr"><di=
v dir=3D"ltr"><div dir=3D"ltr">Guillaume Laforge<br>Apache Groovy committer=
 &amp; PMC member</div><div dir=3D"ltr">Product Ninja &amp; Advocate at <a =
href=3D"http://restlet.com" target=3D"_blank">Restlet</a><br><div><br></div=
><div>Blog:=C2=A0<a href=3D"http://glaforge.appspot.com/" target=3D"_blank"=
>http://glaforge.appspot.com/</a><div><div>Social: <a href=3D"http://twitte=
r.com/glaforge" target=3D"_blank">@glaforge</a>=C2=A0/ <a href=3D"https://p=
lus.google.com/u/0/114130972232398734985/posts" target=3D"_blank">Google+</=
a></div></div></div></div></div></div></div></div></div>
</div>

--001a1134fe14559de3051f37a4c6--