groovy-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guillaume Laforge <glafo...@gmail.com>
Subject Re: Rolling back change to use ClassValue
Date Tue, 08 Sep 2015 07:52:04 GMT
Or perhaps a kind of feature toggle, with an environment variable?
We use the former mechanism by default, unless this env var is set to true?
That way we can still easily check if the VM bug / behavior is fixed /
changed?

On Tue, Sep 8, 2015 at 9:35 AM, Jochen Theodorou <blackdrag@gmx.org> wrote:

> Am 08.09.2015 09:07, schrieb C├ędric Champeau:
>
>> Hi guys,
>>
>> As some of you may know, I've been investigating a memory leak which
>> involves all versions of Groovy starting from 2.4. The leak comes from a
>> bug in the VM regarding how it handles ClassValue, that Groovy 2.4
>> started using. All VMs are affected (7, 8 and 9) and it's still unclear
>> when this will be fixed. So I would like to suggest to rollback this
>> change for the next release.
>>
>> Basically, this commit:
>>
>> https://github.com/apache/incubator-groovy/commit/97d78e9e52deb52c8e66db501ef208f30384d014
>>
>> It greatly affects Gradle, so I would suggest to make the change ASAP
>> (2.4.5) if everyone agrees.
>>
>
> -1
>
> We can disable it by default till we find a better solution. But we don't
> need to roll it back completely. I am afraid of the fix not being
> applicable later on anymore
>
> bye blackdrag
>
> --
> Jochen "blackdrag" Theodorou
> blog: http://blackdragsview.blogspot.com/
>
>


-- 
Guillaume Laforge
Apache Groovy committer & PMC member
Product Ninja & Advocate at Restlet <http://restlet.com>

Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>

Mime
View raw message