Mailing-List: contact dev-help@groovy.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAL2qGUFW+Q5o7vqQt9L5ca-CgMX6Rsih1p+2=D_4a=D3uCGcmQ@mail.gmail.com>
References: 
 <CAJp7v6DfvA1D17KYXzrEauy_iXxJqNgzW3j+YpjDbppoPfACGA@mail.gmail.com>
 <CAL2qGUFW+Q5o7vqQt9L5ca-CgMX6Rsih1p+2=D_4a=D3uCGcmQ@mail.gmail.com>
From: Keegan Witt <keeganwitt@gmail.com>
Date: Tue, 4 Aug 2015 13:58:09 -0400
Message-ID: 
 <CAL2qGUH1LhRykHx5AmPoYnO+LBr=ErHr0UcGWyTX3u9ztUYOWw@mail.gmail.com>
Subject: Re: JsonOutput and pretty print
To: dev@groovy.incubator.apache.org
Content-Type: multipart/alternative; boundary=001a1147e64c8ce2d2051c80082d

--001a1147e64c8ce2d2051c80082d
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Actually, thinking about this a little more, my suggestion would introduce
an inconsistency for JsonOutput.prettyPrint(String).  All the other
prettyPrints would mean convert to JSON, then pretty print, but
prettyPrint(String) would either assume the String is JSON, or have to
include an extra parameter to communicate whether it is already JSON or
not.  If we were going to do this, your idea is actually better.

-Keegan


On Tue, Aug 4, 2015 at 1:05 PM, Keegan Witt <keeganwitt@gmail.com> wrote:

> If I were to build JsonOutput from scratch today, I'd probably do as you
> propose.  But since we've already gone down the road of a separate method
> for pretty printing, maybe it'd be more consistent to leave
> JsonOutput.toJson() alone and instead add matching JsonOutput.prettyPrint=
()
> methods.  What's everyone else think?
>
> -Keegan
>
> On Tue, Aug 4, 2015 at 2:21 AM, Esteban G=C3=ADnez <eginez@gmail.com> wro=
te:
>
>> JsonOutput
>
>
>

--001a1147e64c8ce2d2051c80082d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Actually, thinking about this a little more, my sugge=
stion would introduce an inconsistency for JsonOutput.prettyPrint(String).=
=C2=A0 All the other prettyPrints would mean convert to JSON, then pretty p=
rint, but prettyPrint(String) would either assume the String is JSON, or ha=
ve to include an extra parameter to communicate whether it is already JSON =
or not.=C2=A0 If we were going to do this, your idea is actually better.<br=
><br></div><div>-Keegan<br></div><div><br></div></div><div class=3D"gmail_e=
xtra"><br><div class=3D"gmail_quote">On Tue, Aug 4, 2015 at 1:05 PM, Keegan=
 Witt <span dir=3D"ltr">&lt;<a href=3D"mailto:keeganwitt@gmail.com" target=
=3D"_blank">keeganwitt@gmail.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_extra">If I were to buil=
d JsonOutput from scratch today, I&#39;d probably do as you propose.=C2=A0 =
But since we&#39;ve already gone down the road of a separate method for pre=
tty printing, maybe it&#39;d be more consistent to leave JsonOutput.toJson(=
) alone and instead add matching JsonOutput.prettyPrint() methods.=C2=A0 Wh=
at&#39;s everyone else think?<br><br></div><div class=3D"gmail_extra">-Keeg=
an<br></div><br><div class=3D"gmail_extra"><div class=3D"gmail_quote">On Tu=
e, Aug 4, 2015 at 2:21 AM, Esteban G=C3=ADnez <span dir=3D"ltr">&lt;<a href=
=3D"mailto:eginez@gmail.com" target=3D"_blank">eginez@gmail.com</a>&gt;</sp=
an> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">JsonOutput</blockquote></div><=
br></div></div>
</blockquote></div><br></div>

--001a1147e64c8ce2d2051c80082d--