Return-Path: X-Original-To: apmail-groovy-dev-archive@minotaur.apache.org Delivered-To: apmail-groovy-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AFE218FE8 for ; Tue, 4 Aug 2015 17:06:05 +0000 (UTC) Received: (qmail 92163 invoked by uid 500); 4 Aug 2015 17:06:05 -0000 Delivered-To: apmail-groovy-dev-archive@groovy.apache.org Received: (qmail 92119 invoked by uid 500); 4 Aug 2015 17:06:05 -0000 Mailing-List: contact dev-help@groovy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.incubator.apache.org Delivered-To: mailing list dev@groovy.incubator.apache.org Received: (qmail 92107 invoked by uid 99); 4 Aug 2015 17:06:04 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Aug 2015 17:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 44AC5DA559 for ; Tue, 4 Aug 2015 17:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.898 X-Spam-Level: ** X-Spam-Status: No, score=2.898 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-eu-west.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Di5r3JQWjt6o for ; Tue, 4 Aug 2015 17:06:03 +0000 (UTC) Received: from mail-qg0-f53.google.com (mail-qg0-f53.google.com [209.85.192.53]) by mx1-eu-west.apache.org (ASF Mail Server at mx1-eu-west.apache.org) with ESMTPS id F2D1E2136C for ; Tue, 4 Aug 2015 17:06:02 +0000 (UTC) Received: by qgeu79 with SMTP id u79so11217318qge.1 for ; Tue, 04 Aug 2015 10:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=klCO87IC0h+m5+MqvKcMRkyGYS63DBf+2PPuCG//5O4=; b=DX3wMAkrElLqbZHK/mFqogG0O7vIlwULNqS+sPCEP3ggkGQ9RwQd4IyvyAKA1HMNcg NmYAscLCG+hHKAfXEX9sP0eVmjIkGK/6Z1FWaO6EM4aAC/0/ZPbAwW/7SAbN67WVsxih i+c9qh9TmrARiRLHlLQfqP3+A7gOWiyXTYGB2oEaoOun5wkaQeOedSYDqqSyLXBJVEf7 Gn1JM/fUGXFVNTBfzl0YNJn6w8NaXEgxPlOANf7dKj4ZaMyd5BwUmtBYsTqmMAuLor/G ad1W3Z7iqmbF4jcddICoALrQHqxBj7SRwLp5oYtpCeXkyRC8YZmEINIdR1d/8wY9243o eWeA== X-Received: by 10.141.23.130 with SMTP id z124mr9269696qhd.55.1438707956424; Tue, 04 Aug 2015 10:05:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.97.9 with HTTP; Tue, 4 Aug 2015 10:05:37 -0700 (PDT) In-Reply-To: References: From: Keegan Witt Date: Tue, 4 Aug 2015 13:05:37 -0400 Message-ID: Subject: Re: JsonOutput and pretty print To: dev@groovy.incubator.apache.org Content-Type: multipart/alternative; boundary=001a11422fe2adaabd051c7f4cc0 --001a11422fe2adaabd051c7f4cc0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable If I were to build JsonOutput from scratch today, I'd probably do as you propose. But since we've already gone down the road of a separate method for pretty printing, maybe it'd be more consistent to leave JsonOutput.toJson() alone and instead add matching JsonOutput.prettyPrint() methods. What's everyone else think? -Keegan On Tue, Aug 4, 2015 at 2:21 AM, Esteban G=C3=ADnez wrote= : > JsonOutput --001a11422fe2adaabd051c7f4cc0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
If I were to build JsonOutput f= rom scratch today, I'd probably do as you propose.=C2=A0 But since we&#= 39;ve already gone down the road of a separate method for pretty printing, = maybe it'd be more consistent to leave JsonOutput.toJson() alone and in= stead add matching JsonOutput.prettyPrint() methods.=C2=A0 What's every= one else think?

-Keegan
On Tue, Aug 4, 2015= at 2:21 AM, Esteban G=C3=ADnez <eginez@gmail.com> wrote:
=
JsonOutput

--001a11422fe2adaabd051c7f4cc0--