Return-Path: X-Original-To: apmail-groovy-dev-archive@minotaur.apache.org Delivered-To: apmail-groovy-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E13761782C for ; Sun, 14 Jun 2015 14:55:43 +0000 (UTC) Received: (qmail 31148 invoked by uid 500); 14 Jun 2015 14:55:43 -0000 Delivered-To: apmail-groovy-dev-archive@groovy.apache.org Received: (qmail 31109 invoked by uid 500); 14 Jun 2015 14:55:43 -0000 Mailing-List: contact dev-help@groovy.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.incubator.apache.org Delivered-To: mailing list dev@groovy.incubator.apache.org Received: (qmail 31099 invoked by uid 99); 14 Jun 2015 14:55:43 -0000 Received: from Unknown (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Jun 2015 14:55:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1EDA21801DF for ; Sun, 14 Jun 2015 14:55:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 3.901 X-Spam-Level: *** X-Spam-Status: No, score=3.901 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, KAM_LIVE=1, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EQFgXY22sVe7 for ; Sun, 14 Jun 2015 14:55:31 +0000 (UTC) Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTPS id E0E4822EF8 for ; Sun, 14 Jun 2015 14:55:30 +0000 (UTC) Received: by wgbhy7 with SMTP id hy7so18453102wgb.2 for ; Sun, 14 Jun 2015 07:55:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=Ag2aEYH12j44ndoRjhgcR8A+/Xroka2jDRJzSTkMR2s=; b=awW78SDwAewYKw8kVQhU7oIIaWpvjI0uYKHGo3w6tPO9RQB6kaLo4b5GgaB7cI4u9D cbuTV68hCXmbM8DwaANgOuXGQNcDvNBUbbsZ4gWrcsrtwKSWoBKipj4c2vp3XY/zTiZv IA/ZIwf1ah3QbXCteSNhBd1dx8I8s2BsdaINVuuxXTQZWUB0i/HTfXRTo+akqYuIcQSE khD2D3G6rbPCVRwl9BswISagpxajpnqHzZGJdV7hloT/jzSNdm0PTIUsWT8dtlPYH3AB nHoTFjS67+xqyXoLR3AgIpyPEYgvKDO36oTi1+2+5Fpl3+GuO+MvvSX9RBccHKAmC5ok q6KA== MIME-Version: 1.0 X-Received: by 10.180.219.42 with SMTP id pl10mr23952949wic.70.1434293723259; Sun, 14 Jun 2015 07:55:23 -0700 (PDT) Received: by 10.180.216.105 with HTTP; Sun, 14 Jun 2015 07:55:23 -0700 (PDT) In-Reply-To: <557D2062.8050601@gmx.org> References: <557D2062.8050601@gmx.org> Date: Sun, 14 Jun 2015 16:55:23 +0200 Message-ID: Subject: Re: Regression in JDK 9? From: =?UTF-8?Q?C=C3=A9dric_Champeau?= To: dev@groovy.incubator.apache.org Content-Type: multipart/alternative; boundary=001a1135f990e0e76e05187b8748 --001a1135f990e0e76e05187b8748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Ok so if we make those changes to 2.4.x as well, then I would suggest to upgrade the wrapper too, because they come as a whole : those changes are directly related to JDK 9 support and not needed otherwise. 2015-06-14 8:34 GMT+02:00 Jochen Theodorou : > Am 13.06.2015 18:36, schrieb C=C3=A9dric Champeau: > >> I am currently investigating building Groovy on the latest JDK 9 b66. >> First of all, I am making the changes on master, which means that only >> Groovy 2.5 will officially support JDK 9, does it sound ok for you guys? >> >> First of all, I had to change some signatures in DGM for the JDK 9 >> generics type checker to be happy. I think those changes make sense, and >> probably the checker in previous versions of the JDK wasn't strict >> enough: >> >> https://github.com/apache/incubator-groovy/commit/83d680877c44072c46bdf2= 212303398ac3b1276e >> >> I also changed the Gradle wrapper to use a snapshot version of Gradle >> 2.6, which fixes JDK 9 compatibility. This is also only done on master. >> > > If you mean that all changes but the gradle wrapper version update to a > snapshot will also go to Groovy 2.4.x, then I am ok with this. But once > there is an official Gradle release with that we should update Groovy 2.4= .x > as well. > > > bye blackdrag > > -- > Jochen "blackdrag" Theodorou > blog: http://blackdragsview.blogspot.com/ > > --001a1135f990e0e76e05187b8748 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Ok so if we make those changes to 2.4.x as well, then I wo= uld suggest to upgrade the wrapper too, because they come as a whole : thos= e changes are directly related to JDK 9 support and not needed otherwise.

2015-06-1= 4 8:34 GMT+02:00 Jochen Theodorou <blackdrag@gmx.org>:
Am 13.06.2015 18:36, schrieb = C=C3=A9dric Champeau:
I am currently investigating building Groovy on the latest JDK 9 b66.
First of all, I am making the changes on master, which means that only
Groovy 2.5 will officially support JDK 9, does it sound ok for you guys?
First of all, I had to change some signatures in DGM for the JDK 9
generics type checker to be happy. I think those changes make sense, and probably the checker in previous versions of the JDK wasn't strict
enough:
https://gi= thub.com/apache/incubator-groovy/commit/83d680877c44072c46bdf2212303398ac3b= 1276e

I also changed the Gradle wrapper to use a snapshot version of Gradle
2.6, which fixes JDK 9 compatibility. This is also only done on master.

 If you mean that all changes but the gradle wrapper version update to a sna= pshot will also go to Groovy 2.4.x, then I am ok with this. But once there = is an official Gradle release with that we should update Groovy 2.4.x as we= ll.


bye blackdrag

--
Jochen "blackdrag" Theodorou
blog: http://blackdragsview.blogspot.com/


--001a1135f990e0e76e05187b8748--