groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sun...@apache.org
Subject [groovy] branch master updated: Clean code smell: throwable should be immutable
Date Sat, 10 Aug 2019 06:59:06 GMT
This is an automated email from the ASF dual-hosted git repository.

sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 4b7dc1d  Clean code smell: throwable should be immutable
4b7dc1d is described below

commit 4b7dc1d7f75ba5354908a91c5d589cfd916bac72
Author: Daniel Sun <sunlan@apache.org>
AuthorDate: Sat Aug 10 14:58:47 2019 +0800

    Clean code smell: throwable should be immutable
---
 .../java/org/apache/groovy/parser/antlr4/GroovySyntaxError.java     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovySyntaxError.java
b/subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovySyntaxError.java
index 7ca8bba..3ce09c2 100644
--- a/subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovySyntaxError.java
+++ b/subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/GroovySyntaxError.java
@@ -24,9 +24,9 @@ package org.apache.groovy.parser.antlr4;
 public class GroovySyntaxError extends AssertionError {
     public static final int LEXER = 0;
     public static final int PARSER = 1;
-    private int source;
-    private int line;
-    private int column;
+    private final int source;
+    private final int line;
+    private final int column;
 
     public GroovySyntaxError(String message, int source, int line, int column) {
         super(message, null);


Mime
View raw message