From commits-return-8691-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Fri May 17 02:45:12 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0839D180782 for ; Fri, 17 May 2019 04:45:11 +0200 (CEST) Received: (qmail 88943 invoked by uid 500); 17 May 2019 02:45:10 -0000 Mailing-List: contact commits-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list commits@groovy.apache.org Received: (qmail 88638 invoked by uid 99); 17 May 2019 02:45:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 May 2019 02:45:09 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 78B838742A; Fri, 17 May 2019 02:45:09 +0000 (UTC) Date: Fri, 17 May 2019 02:45:12 +0000 To: "commits@groovy.apache.org" Subject: [groovy] 03/05: GROOVY-9122: code smell in ProcessingUnit MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: paulk@apache.org In-Reply-To: <155806110921.25340.10904903983896237034@gitbox.apache.org> References: <155806110921.25340.10904903983896237034@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: groovy X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: 50fd92dc30cdfb89d83054e8cc8f5294d807f943 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20190517024509.78B838742A@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. paulk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/groovy.git commit 50fd92dc30cdfb89d83054e8cc8f5294d807f943 Author: Paul King AuthorDate: Fri May 17 11:50:39 2019 +1000 GROOVY-9122: code smell in ProcessingUnit --- .../java/org/codehaus/groovy/control/ProcessingUnit.java | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/codehaus/groovy/control/ProcessingUnit.java b/src/main/java/org/codehaus/groovy/control/ProcessingUnit.java index f4509cd..a16c826 100644 --- a/src/main/java/org/codehaus/groovy/control/ProcessingUnit.java +++ b/src/main/java/org/codehaus/groovy/control/ProcessingUnit.java @@ -58,23 +58,30 @@ public abstract class ProcessingUnit { * Initializes the ProcessingUnit to the empty state. */ public ProcessingUnit(final CompilerConfiguration configuration, final GroovyClassLoader classLoader, final ErrorCollector errorCollector) { + setConfiguration(configuration != null ? configuration : CompilerConfiguration.DEFAULT); setClassLoader(classLoader); - configure(configuration != null ? configuration : CompilerConfiguration.DEFAULT); this.errorCollector = errorCollector != null ? errorCollector : new ErrorCollector(getConfiguration()); + configure(getConfiguration()); } /** * Reconfigures the ProcessingUnit. */ public void configure(CompilerConfiguration configuration) { - this.configuration = configuration; + setConfiguration(configuration); } + /** + * Get the CompilerConfiguration for this ProcessingUnit. + */ public CompilerConfiguration getConfiguration() { return configuration; } - public void setConfiguration(CompilerConfiguration configuration) { + /** + * Sets the CompilerConfiguration for this ProcessingUnit. + */ + public final void setConfiguration(CompilerConfiguration configuration) { this.configuration = configuration; }