groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject [groovy] branch GROOVY_2_5_X updated: GROOVY-8943: @CompileStatic with getAt(int) and getAt(String)
Date Mon, 06 May 2019 11:48:58 GMT
This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch GROOVY_2_5_X
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/GROOVY_2_5_X by this push:
     new 45eadd2  GROOVY-8943: @CompileStatic with getAt(int) and getAt(String)
45eadd2 is described below

commit 45eadd2432329144d1bdb769615b2b958bd5a6ed
Author: Paul King <paulk@asert.com.au>
AuthorDate: Mon May 6 21:44:14 2019 +1000

    GROOVY-8943: @CompileStatic with getAt(int) and getAt(String)
---
 .../transform/stc/StaticTypeCheckingVisitor.java   |  6 ++--
 src/test/groovy/bugs/Groovy8943Bug.groovy          | 40 ++++++++++++++++++++++
 2 files changed, 44 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
index 922c7ce..b134c1a 100644
--- a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
+++ b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
@@ -175,6 +175,7 @@ import static org.codehaus.groovy.ast.tools.GeneralUtils.args;
 import static org.codehaus.groovy.ast.tools.GeneralUtils.binX;
 import static org.codehaus.groovy.ast.tools.GeneralUtils.callX;
 import static org.codehaus.groovy.ast.tools.GeneralUtils.castX;
+import static org.codehaus.groovy.ast.tools.GeneralUtils.localVarX;
 import static org.codehaus.groovy.ast.tools.GeneralUtils.varX;
 import static org.codehaus.groovy.ast.tools.GenericsUtils.findActualTypeByGenericsPlaceholderName;
 import static org.codehaus.groovy.ast.tools.GenericsUtils.makeDeclaringAndActualGenericsTypeMap;
@@ -4098,7 +4099,7 @@ public class StaticTypeCheckingVisitor extends ClassCodeVisitorSupport
{
         if (isArrayOp(op)) {
             // using getPNR() to ignore generics at this point
             // and a different binary expression not to pollute the AST
-            BinaryExpression newExpr = binX(expr.getLeftExpression(), expr.getOperation(),
rightExpression);
+            BinaryExpression newExpr = binX(leftExpression, expr.getOperation(), rightExpression);
             newExpr.setSourcePosition(expr);
             MethodNode method = findMethodOrFail(newExpr, left.getPlainNodeReference(), "getAt",
right.getPlainNodeReference());
             if (method != null && implementsInterfaceOrIsSubclassOf(right, RANGE_TYPE))
{
@@ -4247,7 +4248,8 @@ public class StaticTypeCheckingVisitor extends ClassCodeVisitorSupport
{
             // GROOVY-5521
             // try to identify a getAt method
             typeCheckingContext.pushErrorCollector();
-            MethodCallExpression vcall = callX(varX("_hash_", containerType), "getAt", varX("_index_",
indexType));
+            MethodCallExpression vcall = callX(localVarX("_hash_", containerType), "getAt",
varX("_index_", indexType));
+            vcall.setImplicitThis(false); // GROOVY-8943
             try {
                 visitMethodCallExpression(vcall);
             } finally {
diff --git a/src/test/groovy/bugs/Groovy8943Bug.groovy b/src/test/groovy/bugs/Groovy8943Bug.groovy
new file mode 100644
index 0000000..1721bba
--- /dev/null
+++ b/src/test/groovy/bugs/Groovy8943Bug.groovy
@@ -0,0 +1,40 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one
+ *  or more contributor license agreements.  See the NOTICE file
+ *  distributed with this work for additional information
+ *  regarding copyright ownership.  The ASF licenses this file
+ *  to you under the Apache License, Version 2.0 (the
+ *  "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing,
+ *  software distributed under the License is distributed on an
+ *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ *  KIND, either express or implied.  See the License for the
+ *  specific language governing permissions and limitations
+ *  under the License.
+ */
+package groovy.bugs
+
+class Groovy8943Bug extends GroovyTestCase {
+    void testImplicitGetAtInStaticMethod() {
+        assertScript '''
+            class Pippo {
+                int getAt(String pluto) { return 1 }
+            }
+
+            @groovy.transform.TypeChecked
+            static void method() {
+                def pippo = new Pippo()
+                int ans = pippo.getAt('a')
+                assert ans == 1
+                ans = pippo['a']
+                assert ans == 1
+            }
+
+            method()
+        '''
+    }
+}


Mime
View raw message