groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject [groovy] 12/17: fix unintended illegal access
Date Fri, 19 Apr 2019 01:43:53 GMT
This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch GROOVY_2_5_X
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 5fa977a770755c29a8d74fa0e62344e90837b8d3
Author: Paul King <paulk@asert.com.au>
AuthorDate: Thu Apr 18 21:44:33 2019 +1000

    fix unintended illegal access
---
 src/test/groovy/ui/GroovyMainTest.groovy           | 4 ++++
 src/test/groovy/util/GroovyScriptEngineTest.groovy | 5 ++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/test/groovy/ui/GroovyMainTest.groovy b/src/test/groovy/ui/GroovyMainTest.groovy
index 018bc41..6b8ed29 100644
--- a/src/test/groovy/ui/GroovyMainTest.groovy
+++ b/src/test/groovy/ui/GroovyMainTest.groovy
@@ -18,6 +18,8 @@
  */
 package groovy.ui
 
+import static groovy.test.GroovyAssert.isAtLeastJdk
+
 class GroovyMainTest extends GroovyTestCase {
     private baos = new ByteArrayOutputStream()
     private ps = new PrintStream(baos)
@@ -138,6 +140,8 @@ assert new MyConcreteClass() != null"""
     }
 
     void testGroovyASTDump() {
+        // current xstream causes illegal access errors on JDK9+ - skip on those JDK versions,
get coverage on older versions
+        if (isAtLeastJdk('9.0')) return
 
         def temporaryDirectory = new File("target/tmp/testGroovyXMLAstGeneration/")
         temporaryDirectory.mkdirs()
diff --git a/src/test/groovy/util/GroovyScriptEngineTest.groovy b/src/test/groovy/util/GroovyScriptEngineTest.groovy
index b62e589..568173e 100644
--- a/src/test/groovy/util/GroovyScriptEngineTest.groovy
+++ b/src/test/groovy/util/GroovyScriptEngineTest.groovy
@@ -30,6 +30,8 @@ import org.junit.rules.TemporaryFolder
 import org.junit.runner.RunWith
 import org.junit.runners.JUnit4
 
+import static groovy.test.GroovyAssert.isAtLeastJdk
+
 @RunWith(JUnit4)
 class GroovyScriptEngineTest extends GroovyTestCase {
 
@@ -38,9 +40,10 @@ class GroovyScriptEngineTest extends GroovyTestCase {
 
     @Test
     void createASTDumpWhenScriptIsLoadedByName() {
+        // current xstream causes illegal access errors on JDK9+ - skip on those JDK versions,
get coverage on older versions
+        if (isAtLeastJdk('9.0')) return
 
         def scriptFile = temporaryFolder.newFile('Script1.groovy')
-
         scriptFile << "assert 1 + 1 == 2" // the script just has to have _some_ content
 
         try {


Mime
View raw message