groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject [groovy] branch master updated: minor refactor: remove some codenarc warnings
Date Mon, 01 Apr 2019 13:01:25 GMT
This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git


The following commit(s) were added to refs/heads/master by this push:
     new 0ee6c3f  minor refactor: remove some codenarc warnings
0ee6c3f is described below

commit 0ee6c3f25e6be72e79b40dc798daa5609541beeb
Author: Paul King <paulk@asert.com.au>
AuthorDate: Mon Apr 1 23:01:11 2019 +1000

    minor refactor: remove some codenarc warnings
---
 .../src/main/groovy/groovy/util/FileNameFinder.groovy      | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/subprojects/groovy-ant/src/main/groovy/groovy/util/FileNameFinder.groovy b/subprojects/groovy-ant/src/main/groovy/groovy/util/FileNameFinder.groovy
index f066f52..9fa5b0e 100644
--- a/subprojects/groovy-ant/src/main/groovy/groovy/util/FileNameFinder.groovy
+++ b/subprojects/groovy-ant/src/main/groovy/groovy/util/FileNameFinder.groovy
@@ -25,11 +25,11 @@ package groovy.util
 class FileNameFinder implements IFileNameFinder {
 
     List<String> getFileNames(String basedir, String pattern) {
-        return getFileNames(dir: basedir, includes: pattern)
+        getFileNames(dir: basedir, includes: pattern)
     }
 
     List<String> getFileNames(String basedir, String pattern, String excludesPattern)
{
-        return getFileNames(dir: basedir, includes: pattern, excludes: excludesPattern)
+        getFileNames(dir: basedir, includes: pattern, excludes: excludesPattern)
     }
 
     List<String> getFileNames(Map args) {
@@ -37,10 +37,10 @@ class FileNameFinder implements IFileNameFinder {
         def scanner = ant.fileScanner {
             fileset(args)
         }
-        def fls = []
-        for (f in scanner) {
-            fls << f.getAbsolutePath()
+        List<String> files = []
+        for (File f in scanner) {
+            files << f.absolutePath
         }
-        return fls
+        files
     }
-}
\ No newline at end of file
+}


Mime
View raw message