From commits-return-8071-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Thu Mar 7 07:34:21 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B84AA180654 for ; Thu, 7 Mar 2019 08:34:20 +0100 (CET) Received: (qmail 43292 invoked by uid 500); 7 Mar 2019 07:34:19 -0000 Mailing-List: contact commits-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list commits@groovy.apache.org Received: (qmail 43258 invoked by uid 99); 7 Mar 2019 07:34:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Mar 2019 07:34:19 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 252BD8782E; Thu, 7 Mar 2019 07:34:19 +0000 (UTC) Date: Thu, 07 Mar 2019 07:34:21 +0000 To: "commits@groovy.apache.org" Subject: [groovy] 02/03: typo at junit and missing imports MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: paulk@apache.org In-Reply-To: <155194405894.12725.9718787433409099655@gitbox.apache.org> References: <155194405894.12725.9718787433409099655@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: groovy X-Git-Refname: refs/heads/GROOVY_2_5_X X-Git-Reftype: branch X-Git-Rev: 1065e0aa1919a82d4c773834969d073960fb7a25 X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20190307073419.252BD8782E@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. paulk pushed a commit to branch GROOVY_2_5_X in repository https://gitbox.apache.org/repos/asf/groovy.git commit 1065e0aa1919a82d4c773834969d073960fb7a25 Author: Jorge AuthorDate: Wed Mar 6 23:49:07 2019 +0100 typo at junit and missing imports the geb-junit is wrong (or at least currently is not present at Maven Central) and maybe is more clear to add the two missings import by other hand the example is a little old and it requires a deep review. I'll try to do it in these days --- src/spec/doc/core-testing-guide.adoc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/spec/doc/core-testing-guide.adoc b/src/spec/doc/core-testing-guide.adoc index b7e4679..03bbed4 100644 --- a/src/spec/doc/core-testing-guide.adoc +++ b/src/spec/doc/core-testing-guide.adoc @@ -594,7 +594,7 @@ JUnit4 tests. The module that is needed for JUnit 3/4 support is `geb-junit`: -------------------------------------------------------------------- @Grapes([ @Grab("org.gebish:geb-core:0.9.2"), - @Grab("org.gebish:geb-junit:0.9.2"), + @Grab("org.gebish:geb-junit4:0.9.2"), @Grab("org.seleniumhq.selenium:selenium-firefox-driver:2.26.0"), @Grab("org.seleniumhq.selenium:selenium-support:2.26.0") ]) @@ -605,6 +605,9 @@ The central class in Geb is the `geb.Browser` class. As its name implies it is u [source,groovy] --------------------------------------------------------------------------------------------------- +import geb.Browser +import org.openqa.selenium.firefox.FirefoxDriver + def browser = new Browser(driver: new FirefoxDriver(), baseUrl: 'http://myhost:8080/myapp') // <1> browser.drive { go "/login" // <2>