groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject [groovy] 02/03: typo at junit and missing imports
Date Thu, 07 Mar 2019 07:34:21 GMT
This is an automated email from the ASF dual-hosted git repository.

paulk pushed a commit to branch GROOVY_2_5_X
in repository https://gitbox.apache.org/repos/asf/groovy.git

commit 1065e0aa1919a82d4c773834969d073960fb7a25
Author: Jorge <jagedn@gmail.com>
AuthorDate: Wed Mar 6 23:49:07 2019 +0100

    typo at junit and missing imports
    
    the geb-junit is wrong (or at least currently is not present at Maven Central) and maybe
is more clear to add the two missings import
    
    by other hand the example is a little old and it requires a deep review. I'll try to do
it in these days
---
 src/spec/doc/core-testing-guide.adoc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/spec/doc/core-testing-guide.adoc b/src/spec/doc/core-testing-guide.adoc
index b7e4679..03bbed4 100644
--- a/src/spec/doc/core-testing-guide.adoc
+++ b/src/spec/doc/core-testing-guide.adoc
@@ -594,7 +594,7 @@ JUnit4 tests. The module that is needed for JUnit 3/4 support is `geb-junit`:
 --------------------------------------------------------------------
 @Grapes([
     @Grab("org.gebish:geb-core:0.9.2"),
-    @Grab("org.gebish:geb-junit:0.9.2"),
+    @Grab("org.gebish:geb-junit4:0.9.2"),
     @Grab("org.seleniumhq.selenium:selenium-firefox-driver:2.26.0"),
     @Grab("org.seleniumhq.selenium:selenium-support:2.26.0")
 ])
@@ -605,6 +605,9 @@ The central class in Geb is the `geb.Browser` class. As its name implies
it is u
 
 [source,groovy]
 ---------------------------------------------------------------------------------------------------
+import geb.Browser
+import org.openqa.selenium.firefox.FirefoxDriver
+
 def browser = new Browser(driver: new FirefoxDriver(), baseUrl: 'http://myhost:8080/myapp')
 // <1>
 browser.drive {
     go "/login"                        // <2>


Mime
View raw message