From commits-return-6104-archive-asf-public=cust-asf.ponee.io@groovy.apache.org Tue Apr 3 12:45:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 87758180675 for ; Tue, 3 Apr 2018 12:45:03 +0200 (CEST) Received: (qmail 482 invoked by uid 500); 3 Apr 2018 10:45:02 -0000 Mailing-List: contact commits-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list commits@groovy.apache.org Received: (qmail 468 invoked by uid 99); 3 Apr 2018 10:45:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2018 10:45:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 91DE7E9665; Tue, 3 Apr 2018 10:45:02 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: sunlan@apache.org To: commits@groovy.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: groovy git commit: Unnecessary zero length array usage Date: Tue, 3 Apr 2018 10:45:02 +0000 (UTC) Repository: groovy Updated Branches: refs/heads/master fd7aa8115 -> 249d5731e Unnecessary zero length array usage (cherry picked from commit 7d9b504) Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/249d5731 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/249d5731 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/249d5731 Branch: refs/heads/master Commit: 249d5731e3e7152208b3a921c959fde604fc69cd Parents: fd7aa81 Author: sunlan Authored: Tue Apr 3 18:05:28 2018 +0800 Committer: sunlan Committed: Tue Apr 3 18:44:56 2018 +0800 ---------------------------------------------------------------------- src/main/groovy/groovy/lang/MetaClassImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/249d5731/src/main/groovy/groovy/lang/MetaClassImpl.java ---------------------------------------------------------------------- diff --git a/src/main/groovy/groovy/lang/MetaClassImpl.java b/src/main/groovy/groovy/lang/MetaClassImpl.java index 8409bbf..ab8b655 100644 --- a/src/main/groovy/groovy/lang/MetaClassImpl.java +++ b/src/main/groovy/groovy/lang/MetaClassImpl.java @@ -137,7 +137,7 @@ public class MetaClassImpl implements MetaClass, MutableMetaClass { return o1.getName().compareTo(o2.getName()); } }; - private static final MetaMethod[] EMPTY = new MetaMethod[0]; + private static final MetaMethod[] EMPTY = MetaMethod.EMPTY_ARRAY; private static final MetaMethod AMBIGUOUS_LISTENER_METHOD = new DummyMetaMethod(); protected final Class theClass; @@ -189,7 +189,7 @@ public class MetaClassImpl implements MetaClass, MutableMetaClass { List arr = new ArrayList(); arr.addAll(Arrays.asList(metaMethods)); arr.addAll(Arrays.asList(add)); - myNewMetaMethods = arr.toArray(new MetaMethod[0]); + myNewMetaMethods = arr.toArray(MetaMethod.EMPTY_ARRAY); additionalMetaMethods = metaMethods; } else {