Mailing-List: contact commits-help@groovy.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@groovy.apache.org
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: sunlan@apache.org
To: commits@groovy.apache.org
Date: Mon, 11 Dec 2017 02:52:23 -0000
Message-Id: <1f9e4f688f684f45adcae733c52a2026@git.apache.org>
In-Reply-To: <030b3ae979314f5ba7bc0d8c3bba3257@git.apache.org>
References: <030b3ae979314f5ba7bc0d8c3bba3257@git.apache.org>
Subject: [6/6] groovy git commit: Refine CommonCache and its javadoc
archived-at: Mon, 11 Dec 2017 02:52:22 -0000

Refine CommonCache and its javadoc

(cherry picked from commit 61afa2a)


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/8c0c94e8
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/8c0c94e8
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/8c0c94e8

Branch: refs/heads/GROOVY_2_5_X
Commit: 8c0c94e82e6d40539989ca1f8a3d75e7e76bf7fc
Parents: 303e831
Author: sunlan <sunlan@apache.org>
Authored: Mon Dec 11 10:46:12 2017 +0800
Committer: sunlan <sunlan@apache.org>
Committed: Mon Dec 11 10:52:07 2017 +0800

----------------------------------------------------------------------
 .../groovy/runtime/memoize/CommonCache.java     | 21 +++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/8c0c94e8/src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java
----------------------------------------------------------------------
diff --git a/src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java b/src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java
index f9cd925..1bd336d 100644
--- a/src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java
+++ b/src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java
@@ -44,19 +44,20 @@ public class CommonCache<K, V> implements EvictableCache<K, V> {
     private final ReentrantReadWriteLock.WriteLock writeLock = rwl.writeLock();
 
     /**
-     * A cache with unlimited size
+     * Constructs a cache with unlimited size
      */
     public CommonCache() {
         this(new LinkedHashMap<K, V>());
     }
 
     /**
-     * Another LRU cache, which is slower than {@link LRUCache} but will not put same value multi-times concurrently
+     * Constructs a cache with limited size
      * @param initialCapacity initial capacity of the LRU cache
      * @param maxSize max size of the LRU cache
+     * @param accessOrder the ordering mode - <tt>true</tt> for access-order, <tt>false</tt> for insertion-order, see the parameter accessOrder of {@link LinkedHashMap#LinkedHashMap(int, float, boolean)}
      */
-    public CommonCache(final int initialCapacity, final int maxSize) {
-        this(new LinkedHashMap<K, V>(initialCapacity, 0.75f, true) {
+    public CommonCache(final int initialCapacity, final int maxSize, final boolean accessOrder) {
+        this(new LinkedHashMap<K, V>(initialCapacity, 0.75f, accessOrder) {
             @Override
             protected boolean removeEldestEntry(Map.Entry<K, V> eldest) {
                 return size() > maxSize;
@@ -65,7 +66,17 @@ public class CommonCache<K, V> implements EvictableCache<K, V> {
     }
 
     /**
-     * Another LRU cache with the default initial capacity(16)
+     * Constructs a LRU cache with the specified initial capacity and max size.
+     * The LRU cache is slower than {@link LRUCache} but will not put same value multi-times concurrently
+     * @param initialCapacity initial capacity of the LRU cache
+     * @param maxSize max size of the LRU cache
+     */
+    public CommonCache(final int initialCapacity, final int maxSize) {
+        this(initialCapacity, maxSize, true);
+    }
+
+    /**
+     * Constructs a LRU cache with the default initial capacity(16)
      * @param maxSize max size of the LRU cache
      * @see #CommonCache(int, int)
      */