Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 083B7200D0B for ; Wed, 27 Sep 2017 14:01:59 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 067DF1609CA; Wed, 27 Sep 2017 12:01:59 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4A99F1609BC for ; Wed, 27 Sep 2017 14:01:58 +0200 (CEST) Received: (qmail 68927 invoked by uid 500); 27 Sep 2017 12:01:57 -0000 Mailing-List: contact commits-help@groovy.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@groovy.apache.org Delivered-To: mailing list commits@groovy.apache.org Received: (qmail 68917 invoked by uid 99); 27 Sep 2017 12:01:57 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Sep 2017 12:01:57 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 62BBDF571B; Wed, 27 Sep 2017 12:01:57 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: paulk@apache.org To: commits@groovy.apache.org Message-Id: X-Mailer: ASF-Git Admin Mailer Subject: groovy git commit: minor refactor Date: Wed, 27 Sep 2017 12:01:57 +0000 (UTC) archived-at: Wed, 27 Sep 2017 12:01:59 -0000 Repository: groovy Updated Branches: refs/heads/master 0d54b5357 -> 4cc78440d minor refactor Project: http://git-wip-us.apache.org/repos/asf/groovy/repo Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/4cc78440 Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/4cc78440 Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/4cc78440 Branch: refs/heads/master Commit: 4cc78440d88480788ad7fe2573b7460bc8bec93c Parents: 0d54b53 Author: paulk Authored: Wed Sep 27 22:01:49 2017 +1000 Committer: paulk Committed: Wed Sep 27 22:01:49 2017 +1000 ---------------------------------------------------------------------- .../codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/groovy/blob/4cc78440/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java ---------------------------------------------------------------------- diff --git a/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java b/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java index 9188b2d..807449a 100644 --- a/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java +++ b/src/main/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java @@ -1964,7 +1964,7 @@ public class StaticTypeCheckingVisitor extends ClassCodeVisitorSupport { List classNodes = getTemporaryTypesForExpression(exp); if (classNodes != null && !classNodes.isEmpty()) { ArrayList arr = new ArrayList(classNodes.size() + 1); - if (result != null) arr.add(result); + if (result != null && !classNodes.contains(result)) arr.add(result); arr.addAll(classNodes); // GROOVY-7333: filter out Object Iterator iterator = arr.iterator();