groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pa...@apache.org
Subject groovy git commit: trivial refactor
Date Mon, 30 Jan 2017 13:53:11 GMT
Repository: groovy
Updated Branches:
  refs/heads/GROOVY_2_4_X cf2a041ab -> f8dfb29cb


trivial refactor


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/f8dfb29c
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/f8dfb29c
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/f8dfb29c

Branch: refs/heads/GROOVY_2_4_X
Commit: f8dfb29cbb2ebf2017fa0a27e3b6719c80d423c1
Parents: cf2a041
Author: paulk <paulk@asert.com.au>
Authored: Mon Jan 30 23:52:22 2017 +1000
Committer: paulk <paulk@asert.com.au>
Committed: Mon Jan 30 23:52:54 2017 +1000

----------------------------------------------------------------------
 gradle/pomconfigurer.gradle                     |  3 ++
 .../groovy/classgen/AnnotationVisitor.java      | 31 ++++++++++++++------
 2 files changed, 25 insertions(+), 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/f8dfb29c/gradle/pomconfigurer.gradle
----------------------------------------------------------------------
diff --git a/gradle/pomconfigurer.gradle b/gradle/pomconfigurer.gradle
index 2877e8a..3f3f291 100644
--- a/gradle/pomconfigurer.gradle
+++ b/gradle/pomconfigurer.gradle
@@ -579,6 +579,9 @@ project.ext.pomConfigureClosureWithoutTweaks = {
             contributor {
                 name 'Alan Green'
             }
+            contributor {
+                name 'Alex Popescu'
+            }
         }
         mailingLists {
             mailingList {

http://git-wip-us.apache.org/repos/asf/groovy/blob/f8dfb29c/src/main/org/codehaus/groovy/classgen/AnnotationVisitor.java
----------------------------------------------------------------------
diff --git a/src/main/org/codehaus/groovy/classgen/AnnotationVisitor.java b/src/main/org/codehaus/groovy/classgen/AnnotationVisitor.java
index cc7d77c..c77bb70 100644
--- a/src/main/org/codehaus/groovy/classgen/AnnotationVisitor.java
+++ b/src/main/org/codehaus/groovy/classgen/AnnotationVisitor.java
@@ -18,13 +18,26 @@
  */
 package org.codehaus.groovy.classgen;
 
-import java.util.*;
 import java.lang.reflect.Field;
 import java.lang.reflect.Modifier;
+import java.util.List;
+import java.util.Map;
 
-import org.codehaus.groovy.ast.*;
+import org.codehaus.groovy.ast.ASTNode;
+import org.codehaus.groovy.ast.AnnotationNode;
+import org.codehaus.groovy.ast.ClassHelper;
+import org.codehaus.groovy.ast.ClassNode;
+import org.codehaus.groovy.ast.FieldNode;
+import org.codehaus.groovy.ast.MethodNode;
+import org.codehaus.groovy.ast.expr.AnnotationConstantExpression;
+import org.codehaus.groovy.ast.expr.ClassExpression;
+import org.codehaus.groovy.ast.expr.ClosureExpression;
+import org.codehaus.groovy.ast.expr.ConstantExpression;
+import org.codehaus.groovy.ast.expr.Expression;
+import org.codehaus.groovy.ast.expr.ListExpression;
+import org.codehaus.groovy.ast.expr.PropertyExpression;
+import org.codehaus.groovy.ast.expr.VariableExpression;
 import org.codehaus.groovy.ast.stmt.ReturnStatement;
-import org.codehaus.groovy.ast.expr.*;
 import org.codehaus.groovy.control.ErrorCollector;
 import org.codehaus.groovy.control.SourceUnit;
 import org.codehaus.groovy.control.messages.SyntaxErrorMessage;
@@ -32,12 +45,12 @@ import org.codehaus.groovy.syntax.SyntaxException;
 import org.codehaus.groovy.vmplugin.VMPluginFactory;
 
 /**
- * An Annotation visitor responsible with:
- * - reading annotation metadata (@Retention, @Target, attribute types)
- * - verify that an <code>AnnotationNode</code> conforms to annotation meta
- * - enhancing an <code>AnnotationNode</code> AST to reflect real annotation
meta
- *
- * @author <a href='mailto:the[dot]mindstorm[at]gmail[dot]com'>Alex Popescu</a>
+ * An Annotation visitor responsible for:
+ * <ul>
+ * <li>reading annotation metadata (@Retention, @Target, attribute types)</li>
+ * <li>verify that an <code>AnnotationNode</code> conforms to annotation
meta</li>
+ * <li>enhancing an <code>AnnotationNode</code> AST to reflect real annotation
meta</li>
+ * </ul>
  */
 public class AnnotationVisitor {
     private SourceUnit source;


Mime
View raw message