groovy-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwagenleit...@apache.org
Subject groovy git commit: ManagedReference#finalizeReference stackoverflow on call to removeStallEntries
Date Sun, 24 Jan 2016 18:01:35 GMT
Repository: groovy
Updated Branches:
  refs/heads/master 428dad537 -> 57cb5e8da


ManagedReference#finalizeReference stackoverflow on call to removeStallEntries

The initial call to finalizeReference will normally originate from ReferenceManager#removeStallEntries.
 Having finalizeReference call removeStallEntries (via clear) can create a cycle resulting
in a stackoverflow.


Project: http://git-wip-us.apache.org/repos/asf/groovy/repo
Commit: http://git-wip-us.apache.org/repos/asf/groovy/commit/57cb5e8d
Tree: http://git-wip-us.apache.org/repos/asf/groovy/tree/57cb5e8d
Diff: http://git-wip-us.apache.org/repos/asf/groovy/diff/57cb5e8d

Branch: refs/heads/master
Commit: 57cb5e8dad75380219e499b31f10e4500c41cc86
Parents: 428dad5
Author: John Wagenleitner <jwagenleitner@apache.org>
Authored: Sun Jan 24 09:58:50 2016 -0800
Committer: John Wagenleitner <jwagenleitner@apache.org>
Committed: Sun Jan 24 10:01:02 2016 -0800

----------------------------------------------------------------------
 src/main/org/codehaus/groovy/util/ManagedReference.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/groovy/blob/57cb5e8d/src/main/org/codehaus/groovy/util/ManagedReference.java
----------------------------------------------------------------------
diff --git a/src/main/org/codehaus/groovy/util/ManagedReference.java b/src/main/org/codehaus/groovy/util/ManagedReference.java
index 4c211c3..391f522 100644
--- a/src/main/org/codehaus/groovy/util/ManagedReference.java
+++ b/src/main/org/codehaus/groovy/util/ManagedReference.java
@@ -50,6 +50,6 @@ public class ManagedReference<T> implements Finalizable {
     }
     
     public void finalizeReference(){
-        clear();
+        ref.clear();
     }
 }   
\ No newline at end of file


Mime
View raw message