griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [griffin] chitralverma edited a comment on pull request #569: [GRIFFIN-326] New Data Connector for Elasticsearch
Date Mon, 01 Jun 2020 19:11:56 GMT

chitralverma edited a comment on pull request #569:
URL: https://github.com/apache/griffin/pull/569#issuecomment-637049574


   @guoyuepeng @wankunde I've made the necessary changes in this PR to fix failures and the
build is now a success. Can you please review and merge this now.
   
   Key Changes since failures:
   - As per @icesmartjuan suggestion, updated the version of `typescript`.
   - As per @wankunde suggestion, refactored `FileBasedDataConnector`.
   - Refactored `ElasticSearchDataConnectorTest` as it was too resource-intensive for the
builder.
   - Minor changes to other connectors as they were suppressing read exceptions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message