From dev-return-4615-archive-asf-public=cust-asf.ponee.io@griffin.apache.org Mon Sep 23 13:08:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BDCFA180651 for ; Mon, 23 Sep 2019 15:08:17 +0200 (CEST) Received: (qmail 69209 invoked by uid 500); 23 Sep 2019 13:08:17 -0000 Mailing-List: contact dev-help@griffin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@griffin.apache.org Delivered-To: mailing list dev@griffin.apache.org Received: (qmail 69195 invoked by uid 99); 23 Sep 2019 13:08:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Sep 2019 13:08:17 +0000 From: GitBox To: dev@griffin.apache.org Subject: [GitHub] [griffin] guoyuepeng commented on a change in pull request #538: [GRIFFIN-289]New feature for griffin COMPLETENESS dq type Message-ID: <156924409704.20693.874946177602388046.gitbox@gitbox.apache.org> Date: Mon, 23 Sep 2019 13:08:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit guoyuepeng commented on a change in pull request #538: [GRIFFIN-289]New feature for griffin COMPLETENESS dq type URL: https://github.com/apache/griffin/pull/538#discussion_r327103616 ########## File path: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/CompletenessExpr2DQSteps.scala ########## @@ -85,8 +85,16 @@ case class CompletenessExpr2DQSteps(context: DQContext, // 2. incomplete record val incompleteRecordsTableName = "__incompleteRecords" - val completeWhereClause = aliases.map(a => s"`${a}` IS NOT NULL").mkString(" AND ") - val incompleteWhereClause = s"NOT (${completeWhereClause})" + val errorConfs: Seq[RuleErrorConfParam] = ruleParam.getErrorConfs + var incompleteWhereClause: String = "" + if (errorConfs.size == 0) { + // old completeness way Review comment: ok, we can comment here as "without errorconf", old is some kind of too abstract. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services