griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [griffin] bhlx3lyx7 commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep
Date Thu, 22 Aug 2019 14:57:29 GMT
bhlx3lyx7 commented on a change in pull request #526: [GRIFFIN-283] Move sink steps into TransformStep
URL: https://github.com/apache/griffin/pull/526#discussion_r316726494
 
 

 ##########
 File path: measure/src/main/scala/org/apache/griffin/measure/step/builder/dsl/transform/Expr2DQSteps.scala
 ##########
 @@ -32,6 +33,10 @@ trait Expr2DQSteps extends Loggable with Serializable {
 
   def getDQSteps(): Seq[DQStep]
 
+  implicit def recoredWriteStepToList(writeStep: RecordWriteStep): List[WriteStep] = writeStep
:: Nil
+
+  implicit def metricsWriteStepToList(writeStep: MetricWriteStep): List[WriteStep] = writeStep
:: Nil
 
 Review comment:
   It's a little weird to implicitly change a `WriteStep` into `List[WriteStep]`, it would
be clearer and easier for reading if we just pass the List parameter as the function defined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message