griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (GRIFFIN-240) [Service] Return JobInstance in response to a call Trigger job by id
Date Tue, 19 Mar 2019 12:35:00 GMT

     [ https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=215416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215416
]

ASF GitHub Bot logged work on GRIFFIN-240:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/19 12:34
            Start Date: 19/Mar/19 12:34
    Worklog Time Spent: 10m 
      Work Description: aborgatin commented on pull request #489: GRIFFIN-240 Return JobInstanceBean
in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266863242
 
 

 ##########
 File path: service/src/main/java/org/apache/griffin/core/job/JobController.java
 ##########
 @@ -115,8 +120,19 @@ public JobHealth getHealthInfo() {
     }
 
     @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
-    @ResponseStatus(HttpStatus.NO_CONTENT)
-    public void triggerJob(@PathVariable("id") Long id) throws SchedulerException {
-        jobService.triggerJobById(id);
+    @ResponseStatus(HttpStatus.OK)
+    public JobInstanceBean triggerJob(@PathVariable("id") Long id, @RequestBody(required
= false) String request) throws SchedulerException {
+        return jobService.triggerJobById(id, extractTimeOut(request));
+    }
+
+    private long extractTimeOut(String request) {
 
 Review comment:
   Of course I can remove this param from request and use is only as configuration property.
Sometimes there are situations when we need to wait for the creation of JobInstanceBean, but
in other situations it is not necessary (see https://github.com/apache/griffin/pull/489#discussion_r266855423)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 215416)
    Time Spent: 1h 50m  (was: 1h 40m)

> [Service] Return JobInstance in response to a call Trigger job by id 
> ---------------------------------------------------------------------
>
>                 Key: GRIFFIN-240
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-240
>             Project: Griffin (Incubating)
>          Issue Type: Improvement
>            Reporter: Aleksandr Borgatin
>            Priority: Major
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
>     @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
>     @ResponseStatus(HttpStatus.NO_CONTENT)
>     public void triggerJob(@PathVariable("id") Long id) throws SchedulerException {
>         jobService.triggerJobById(id);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message