griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From guoyuepeng <...@git.apache.org>
Subject [GitHub] incubator-griffin issue #444: Define griffin plain-vanilla hook.
Date Fri, 09 Nov 2018 02:38:25 GMT
Github user guoyuepeng commented on the issue:

    https://github.com/apache/incubator-griffin/pull/444
  
    spring beans framework introspect introspect top-level beans, that is why List<GriffinHook>
not wired on.
    I agree with @gavlyukovskiy  getbean by name is not as good as getbean by type.
    But how to balance between 'extensible' and usable, I am not sure about this.
    Do we need to support inspect List<GriffinHook> ?
    Can we provide several implements in configuration like GriffinHook1, GriffionHook2...
and autowired into List<GriffinHook>?


---

Mime
View raw message