griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From William Guo <gu...@apache.org>
Subject Re: [jira] [Commented] (GRIFFIN-206) Wrong sign of time zone offset when created from UI
Date Sun, 14 Oct 2018 02:23:57 GMT
don't worry, we can do it in angular side.

On Sun, Oct 14, 2018 at 4:17 AM ASF GitHub Bot (JIRA) <jira@apache.org>
wrote:

>
>     [
> https://issues.apache.org/jira/browse/GRIFFIN-206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16649102#comment-16649102
> ]
>
> ASF GitHub Bot commented on GRIFFIN-206:
> ----------------------------------------
>
> Github user chemikadze commented on a diff in the pull request:
>
>
> https://github.com/apache/incubator-griffin/pull/435#discussion_r224970940
>
>     --- Diff: ui/angular/src/app/job/create-job/batch/batch.component.ts
> ---
>     @@ -134,8 +134,8 @@ export class BatchComponent implements OnInit,
> AfterViewChecked {
>            return false;
>          }
>          this.measureid = this.getMeasureId();
>     -    let time = new Date().getTimezoneOffset() / 60;
>     -    let timezone = "GMT" + time + ":00";
>     +    let time = -(new Date().getTimezoneOffset() / 60);
>     --- End diff --
>
>     @guoyuepeng @ashutakGG Moved to utility function. Angular is not my
> specialty, I was really surprised how much complexity Angular community has
> about it.
>
>
> > Wrong sign of time zone offset when created from UI
> > ---------------------------------------------------
> >
> >                 Key: GRIFFIN-206
> >                 URL: https://issues.apache.org/jira/browse/GRIFFIN-206
> >             Project: Griffin (Incubating)
> >          Issue Type: Bug
> >            Reporter: Nikolay Sokolov
> >            Assignee: Nikolay Sokolov
> >            Priority: Major
> >
> > When job is created from UI, time zone offset is created by this piece
> of code:
> > {code:none}
> > let time = new Date().getTimezoneOffset() / 60;
> > let timezone = "GMT" + time + ":00";
> > {code}
> > Problem is, that for GMT-7 it yields positive number, resulting in
> calculated timezone to be GMT+7.
> > Turns out that that some formats are not parsed properly, at least
> UTCXX:XX format used by UI is not processed correctly, and GMTXX:XX
> (without signs):
> > {code:none}
> > scala> java.util.TimeZone.getTimeZone("GMT6")
> > res9: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("GMT+6")
> > res10: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT+06:00",offset=21600000,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("UTC+6")
> > res11: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > scala> java.util.TimeZone.getTimeZone("UTC-6(CST)")
> > res12: java.util.TimeZone =
> sun.util.calendar.ZoneInfo[id="GMT",offset=0,dstSavings=0,useDaylight=false,transitions=0,lastRule=null]
> > {code}
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v7.6.3#76005)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message