griffin-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ashutakGG <...@git.apache.org>
Subject [GitHub] incubator-griffin pull request #435: [GRIFFIN-206] fix job timezone when cre...
Date Thu, 11 Oct 2018 14:55:19 GMT
Github user ashutakGG commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/435#discussion_r224459867
  
    --- Diff: service/src/test/java/org/apache/griffin/core/util/TimeUtilTest.java ---
    @@ -110,4 +111,36 @@ public void testFormatWithIllegalException() {
             TimeUtil.format(format, time, TimeZone.getTimeZone(timeZone));
         }
     
    +    @Test
    +    public void testGetTimeZone() {
    +        HashMap<String, String> tests = new HashMap<>();
    --- End diff --
    
    Please, use interface name instead of implementation. 


---

Mime
View raw message