gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [gora] djkevincr commented on a change in pull request #195: [GORA-638] Add gora-ignite into the gora-tutorial module
Date Mon, 07 Oct 2019 14:00:35 GMT
djkevincr commented on a change in pull request #195: [GORA-638] Add gora-ignite into the gora-tutorial
module
URL: https://github.com/apache/gora/pull/195#discussion_r332034950
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -1012,6 +1012,17 @@
         <version>${project.version}</version>
         <type>test-jar</type>
       </dependency>
+      <dependency>
 
 Review comment:
   ```
    <dependency>
           <groupId>org.apache.gora</groupId>
           <artifactId>gora-redis</artifactId>
           <version>${project.version}</version>
         </dependency>
         <dependency>
           <groupId>org.apache.gora</groupId>
           <artifactId>gora-redis</artifactId>
           <version>${project.version}</version>
           <type>test-jar</type>
         </dependency>
   ```
   Do we need these redis dependencies as part of this PR? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message