gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [gora] alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
Date Sun, 17 Mar 2019 17:24:03 GMT
alfonsonishikawa commented on a change in pull request #135: Goraexplorer needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r266249623
 
 

 ##########
 File path: gora-core/src/main/java/org/apache/gora/store/DataStoreFactory.java
 ##########
 @@ -412,7 +484,7 @@ public static String getMappingFile(Properties properties, DataStore<?,?>
store
     return mappingFilename;
   }
 
-  private static String getDefaultDataStore(Properties properties) {
+  public static String getDefaultDataStore(Properties properties) {
 
 Review comment:
   Sadly the MetadataAnalyzer (to retrieve native information from the backend) depends on
the name of the DataStore.
   I acknowledge I went into a rush about implementing the feature, so any suggestions about
are welcomed :)
   I see you found out why by yourself! (https://github.com/apache/gora/pull/135/files/2974126a934bddc526830182b402767c0f1eefd0?file-filters%5B%5D=.java&hide-deleted-files=true#diff-d9701987f6844457a897d30a5786e5a4)
:D

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message