gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nishadi <...@git.apache.org>
Subject [GitHub] gora pull request #132: Gora-444 : Add #size() to Result API
Date Wed, 28 Mar 2018 12:15:30 GMT
Github user nishadi commented on a diff in the pull request:

    https://github.com/apache/gora/pull/132#discussion_r177727883
  
    --- Diff: gora-jcache/src/main/java/org/apache/gora/jcache/query/JCacheResult.java ---
    @@ -82,4 +82,9 @@ protected boolean nextInner() throws IOException {
         return true;
       }
     
    +  @Override
    +  public int size() {
    +    return cacheKeySet.size();
    +  }
    +
    --- End diff --
    
    @carlosrmng It is a good practice if you can avoid empty lines like this :)  


---

Mime
View raw message