gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From renato2099 <...@git.apache.org>
Subject [GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora
Date Thu, 15 Mar 2018 15:52:51 GMT
Github user renato2099 commented on a diff in the pull request:

    https://github.com/apache/gora/pull/131#discussion_r174720104
  
    --- Diff: gora-lucene/src/main/java/org/apache/gora/lucene/store/LuceneMapping.java ---
    @@ -0,0 +1,50 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.gora.lucene.store;
    +
    +import java.util.Collection;
    +import java.util.HashMap;
    +
    +public class LuceneMapping {
    +  private final HashMap<String,String> mapping;
    +  private String primaryKey;
    --- End diff --
    
    Clarification question:
    How does the primaryKey relates to the actual mapping? I mean I guess I can have a Gora
record containing only a primary key, but that would mean that the mapping is actually empty,
right? Or does this scenario can never happen? :)


---

Mime
View raw message