gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From renato2099 <...@git.apache.org>
Subject [GitHub] gora pull request #131: GORA-266 Lucene datastore for Gora
Date Thu, 15 Mar 2018 15:52:51 GMT
Github user renato2099 commented on a diff in the pull request:

    https://github.com/apache/gora/pull/131#discussion_r174716112
  
    --- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
    @@ -434,7 +432,7 @@ public static void writeBoolArray(DataOutput out, boolean[] boolArray)
         WritableUtils.writeVInt(out, boolArray.length);
     
         byte b = 0;
    -    int i = 0;
    +    int i;
    --- End diff --
    
    nitpick:
    why don't just make "i" a loop variable? It is not needed outside of it anyways


---

Mime
View raw message