gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-512) Fail at the time of error logging if KeyClass in gora-hbase-mapping is not the same as the one in the data bean
Date Thu, 08 Jun 2017 14:27:18 GMT

    [ https://issues.apache.org/jira/browse/GORA-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16042764#comment-16042764
] 

ASF GitHub Bot commented on GORA-512:
-------------------------------------

GitHub user nishadi opened a pull request:

    https://github.com/apache/gora/pull/109

    GORA-512 Add HBase configuration exception for erroneous mapping file and test

    This PR resolves GORA-512 by adding the necessary exception for erroneous mapping files
and a test case to capture it. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nishadi/gora issue-512

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit d5e5560bac73885a34de1df66ea998f76006bc28
Author: nishadi <ndimeshi@gmail.com>
Date:   2017-06-08T14:22:10Z

    Add HBase configuration exception for erroneous mapping file and test

----


> Fail at the time of error logging if KeyClass in gora-hbase-mapping is not the same as
the one in the data bean
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: GORA-512
>                 URL: https://issues.apache.org/jira/browse/GORA-512
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: gora-hbase
>            Reporter: Nishadi Kirielle
>            Assignee: Nishadi Kirielle
>            Priority: Minor
>
> In the current implementation, when reading the HBase mapping file, if the HBase mapping
file does not have a matching key class and name to the data bean, it only logs that information.[1]
It does not fail at the time of detecting it. It fails only at the time of building the mapper
[2] when it detects the table name is null. It will be better if it can fail at the time of
detecting that mapping file is missing the corresponding class. 
> [1]. https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L797
> [2]. https://github.com/apache/gora/blob/master/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java#L815



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message