gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From nishadi <...@git.apache.org>
Subject [GitHub] gora pull request #111: [WIP] GORA-502 Implement Aerospike Data Store
Date Mon, 26 Jun 2017 17:45:28 GMT
Github user nishadi commented on a diff in the pull request:

    https://github.com/apache/gora/pull/111#discussion_r124073946
  
    --- Diff: gora-aerospike/src/test/java/org/apache/gora/aerospike/GoraAerospikeTestDriver.java
---
    @@ -0,0 +1,78 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.gora.aerospike;
    +
    +import org.apache.gora.GoraTestDriver;
    +import org.apache.gora.aerospike.store.AerospikeStore;
    +import org.apache.gora.persistency.Persistent;
    +import org.apache.gora.store.DataStore;
    +import org.apache.gora.store.DataStoreFactory;
    +import org.apache.gora.util.GoraException;
    +import org.testcontainers.containers.GenericContainer;
    +
    +import java.util.Properties;
    +
    +/**
    + * Helper class for third part tests using gora-aerospike backend.
    + * @see GoraTestDriver
    + */
    +public class GoraAerospikeTestDriver extends GoraTestDriver {
    +
    +  private GenericContainer aerospikeContainer;
    --- End diff --
    
    For the GoraTestDriver class we can add this field( GenericContaine), and in the instances
when we need to use the docker based setup environment, we can provide a separate constructor
to handle the container. I will look further into generalizing this further to create the
docker instance at the DataStoreTestBase level. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message