Mailing-List: contact dev-help@gora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gora.apache.org
Date: Sun, 28 May 2017 12:38:04 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: dev@gora.apache.org
Message-ID: <JIRA.13075455.1495970425000.311750.1495975084974@Atlassian.JIRA>
In-Reply-To: <JIRA.13075455.1495970425000@Atlassian.JIRA>
References: <JIRA.13075455.1495970425000@Atlassian.JIRA> <JIRA.13075455.1495970425906@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GORA-510) Conform Query.setEndKey to inclusive
 query for HBaseStore
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Sun, 28 May 2017 12:38:09 -0000


    [ https://issues.apache.org/jira/browse/GORA-510?page=3Dcom.atlassian.j=
ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D160278=
05#comment-16027805 ]=20

ASF GitHub Bot commented on GORA-510:
-------------------------------------

GitHub user alfonsonishikawa opened a pull request:

    https://github.com/apache/gora/pull/106

    GORA-510 Conform Query.setEndKey to inclusive query for HBaseStore

    Fix + enabled ignored Tests in HBase module.
    Link to Jira: https://issues.apache.org/jira/browse/GORA-510

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alfonsonishikawa/gora GORA-510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
   =20
----
commit b9b91ae68d5ecc7a94d9aa14f3a93bb892c5da38
Author: Alfonso Nishikawa Mu=C3=B1umer <alfonso.nishikawa@gmail.com>
Date:   2017-05-28T12:36:26Z

    GORA-510 Conform Query.setEndKey to inclusive query for HBaseStore
    Fix + enabled ignored Tests

----


> Conform Query.setEndKey to inclusive query for HBaseStore
> ---------------------------------------------------------
>
>                 Key: GORA-510
>                 URL: https://issues.apache.org/jira/browse/GORA-510
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase
>    Affects Versions: 0.6, 0.7, 0.8
>            Reporter: Alfonso Nishikawa
>            Assignee: Alfonso Nishikawa
>            Priority: Minor
>              Labels: query
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The endKey query option does not work properly in HBase: Gora's query int=
eface defines it as 'inclusive' while HBase behaves 'exclusive'.
> The tests have been @ignored temporarily (since 2014! "nothing is more pe=
rmanent than a temporary solution" ;) as shown at TestHBaseStore ([1]).
> There is a "TODO" with the message "raise an issue for HBase to allow us =
to specify if the endRow will be inclusive or exclusive", but HBase documen=
tation states:
> "Note: In order to make stopRow inclusive add a trailing 0 byte"
> So: I propose to update HBaseStore to conform Gora's interface based on H=
Base's solution.
> [1] https://github.com/apache/gora/blob/apache-gora-0.7/gora-hbase/src/te=
st/java/org/apache/gora/hbase/store/TestHBaseStore.java#L248


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)