gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-510) Conform Query.setEndKey to inclusive query for HBaseStore
Date Sun, 28 May 2017 12:38:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027805#comment-16027805
] 

ASF GitHub Bot commented on GORA-510:
-------------------------------------

GitHub user alfonsonishikawa opened a pull request:

    https://github.com/apache/gora/pull/106

    GORA-510 Conform Query.setEndKey to inclusive query for HBaseStore

    Fix + enabled ignored Tests in HBase module.
    Link to Jira: https://issues.apache.org/jira/browse/GORA-510

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/alfonsonishikawa/gora GORA-510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit b9b91ae68d5ecc7a94d9aa14f3a93bb892c5da38
Author: Alfonso Nishikawa Muñumer <alfonso.nishikawa@gmail.com>
Date:   2017-05-28T12:36:26Z

    GORA-510 Conform Query.setEndKey to inclusive query for HBaseStore
    Fix + enabled ignored Tests

----


> Conform Query.setEndKey to inclusive query for HBaseStore
> ---------------------------------------------------------
>
>                 Key: GORA-510
>                 URL: https://issues.apache.org/jira/browse/GORA-510
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-hbase
>    Affects Versions: 0.6, 0.7, 0.8
>            Reporter: Alfonso Nishikawa
>            Assignee: Alfonso Nishikawa
>            Priority: Minor
>              Labels: query
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> The endKey query option does not work properly in HBase: Gora's query inteface defines
it as 'inclusive' while HBase behaves 'exclusive'.
> The tests have been @ignored temporarily (since 2014! "nothing is more permanent than
a temporary solution" ;) as shown at TestHBaseStore ([1]).
> There is a "TODO" with the message "raise an issue for HBase to allow us to specify if
the endRow will be inclusive or exclusive", but HBase documentation states:
> "Note: In order to make stopRow inclusive add a trailing 0 byte"
> So: I propose to update HBaseStore to conform Gora's interface based on HBase's solution.
> [1] https://github.com/apache/gora/blob/apache-gora-0.7/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java#L248



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message