gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alfonso Nishikawa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-255) Remove deprecated methods from DataStoreTestBase
Date Wed, 31 May 2017 21:18:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031977#comment-16031977
] 

Alfonso Nishikawa commented on GORA-255:
----------------------------------------

Hi, my guess is that we need a MemStoreTestDriver before removing those two deprecated methods.
All datastores except MemStore create employeeStore and webPageStore through an especific
TestDriver for each module at this line [1].

The particular TestDriver is configured statically in Test*Store. For example, here in TestHBaseStore
[2], where it configures GoraHBaseTestDriver to be used.

@[~nishadi]: My suggestion is that we would need a MemStoreTestDriver, which will be configured
at MemStoreTest (as in HBase). What do you think?
I am only talking theoretically. I never dig that deep on this.

Thank you!


Gora 0.7 source code links:

[1] https://github.com/apache/gora/blob/apache-gora-0.7/gora-core/src/test/java/org/apache/gora/store/DataStoreTestBase.java#L91

[2] https://github.com/apache/gora/blob/apache-gora-0.7/gora-hbase/src/test/java/org/apache/gora/hbase/store/TestHBaseStore.java#L53


> Remove deprecated methods from DataStoreTestBase 
> -------------------------------------------------
>
>                 Key: GORA-255
>                 URL: https://issues.apache.org/jira/browse/GORA-255
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: 0.4
>            Reporter: Apostolos Giannakidis
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>              Labels: test
>             Fix For: 0.8
>
>
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class DataStoreTestBase. Their
concrete implementations from the subclasses that extend the DataStoreTestBase should also
be removed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message