gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Renato Javier Marroquín Mogrovejo (JIRA) <j...@apache.org>
Subject [jira] [Commented] (GORA-255) Remove deprecated methods from DataStoreTestBase
Date Wed, 31 May 2017 20:12:04 GMT

    [ https://issues.apache.org/jira/browse/GORA-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031862#comment-16031862

Renato Javier Marroquín Mogrovejo commented on GORA-255:

I think we could mark them as deprecated for one release, and then take them out on the next
one, so people are aware that we will remove such methods. But in this case as they are only
used in the MemStoreTest, I think it should be fine to take them out.
[~lewismc] [~alfonso.nishikawa] any objections?

> Remove deprecated methods from DataStoreTestBase 
> -------------------------------------------------
>                 Key: GORA-255
>                 URL: https://issues.apache.org/jira/browse/GORA-255
>             Project: Apache Gora
>          Issue Type: Improvement
>          Components: testing
>    Affects Versions: 0.4
>            Reporter: Apostolos Giannakidis
>            Assignee: Apostolos Giannakidis
>            Priority: Minor
>              Labels: test
>             Fix For: 0.8
> The abstract class DataStoreTestBase contains 2 deprecated methods:
> DataStore<String, Employee> createEmployeeDataStore()
> DataStore<String, WebPage> createWebPageDataStore()
> These methods were useful in the past but they seem not to be useful now.
> I believe that they should be removed from the abstract class DataStoreTestBase. Their
concrete implementations from the subclasses that extend the DataStoreTestBase should also
be removed.

This message was sent by Atlassian JIRA

View raw message