Mailing-List: contact dev-help@gora.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@gora.apache.org
From: cloudysunny14 <git@git.apache.org>
To: dev@gora.apache.org
Reply-To: dev@gora.apache.org
References: <git-pr-96-gora@git.apache.org>
In-Reply-To: <git-pr-96-gora@git.apache.org>
Subject: [GitHub] gora issue #96: Fixed issue GORA-472
Content-Type: text/plain
Message-Id: <20170223103707.37FF0DF986@git1-us-west.apache.org>
Date: Thu, 23 Feb 2017 10:37:07 +0000 (UTC)
archived-at: Thu, 23 Feb 2017 10:37:09 -0000

Github user cloudysunny14 commented on the issue:

    https://github.com/apache/gora/pull/96
  
    I'm sorry for reopen this PR.
    
    I think that the cause of TestHBaseStore#testDeleteByQuery failure is the Delete#addColumn(byte[] family, byte[] qualifier) this delete the latest version of the specified column.
    
    Examples are as follows:
    
    * Delete#addColumn(byte[] family, byte[] qualifier)
    
    Put
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=4
    Put
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Put/vlen=35/seqid=6
    DELETE via Delete#addColumn (It does a get to find the latest versions timestamp and delete latest version of value)
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434377/Delete/vlen=0/seqid=7
    GET
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487824434288/Put/vlen=35/seqid=0
    
    
    * Delete#addColumns(byte[] family, byte[] qualifier)
    
    PUT
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571413/Put/vlen=35/seqid=4
    PUT
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571460/Put/vlen=35/seqid=6
    DELETE via Delete#addColumns (It deletes all versions of the specified column)
    http://baz.com/1.jsp&q=barbaz&p=foo/common:u/1487827571506/DeleteColumn/vlen=0/seqid=7
    GET
    no result(puts are invisible)
    
    I thinks that the TestHBaseStore#testDeleteByQuery intends the latter.
    
    Please try TestHBaseStore after merge https://github.com/apache/gora/pull/95
    
    Kiyonari Harigae


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---