Return-Path: X-Original-To: apmail-gora-dev-archive@www.apache.org Delivered-To: apmail-gora-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 59B4119A21 for ; Mon, 25 Apr 2016 13:40:13 +0000 (UTC) Received: (qmail 54453 invoked by uid 500); 25 Apr 2016 13:40:13 -0000 Delivered-To: apmail-gora-dev-archive@gora.apache.org Received: (qmail 54414 invoked by uid 500); 25 Apr 2016 13:40:13 -0000 Mailing-List: contact dev-help@gora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gora.apache.org Delivered-To: mailing list dev@gora.apache.org Received: (qmail 54334 invoked by uid 99); 25 Apr 2016 13:40:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 13:40:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 172842C14F4 for ; Mon, 25 Apr 2016 13:40:13 +0000 (UTC) Date: Mon, 25 Apr 2016 13:40:13 +0000 (UTC) From: "Kevin Ratnasekera (JIRA)" To: dev@gora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GORA-447) Fix NPE within MemStoreTest.testMemStoreDeleteByQueryFields and failed assertion within MemStoreTest.testGetWithFields MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GORA-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256356#comment-15256356 ] Kevin Ratnasekera commented on GORA-447: ---------------------------------------- Please review pull request on [1] [1] https://github.com/apache/gora/pull/61 Regards Kevin > Fix NPE within MemStoreTest.testMemStoreDeleteByQueryFields and failed assertion within MemStoreTest.testGetWithFields > ---------------------------------------------------------------------------------------------------------------------- > > Key: GORA-447 > URL: https://issues.apache.org/jira/browse/GORA-447 > Project: Apache Gora > Issue Type: Sub-task > Components: gora-core > Reporter: Lewis John McGibbney > Fix For: 0.8 > > > Right now we have two issues post GORA-240, namely > {code} > Failed > org.apache.gora.memory.store.MemStoreTest.testMemStoreDeleteByQueryFields > Failing for the past 1 build (Since Failed#1618 ) > Took 0.29 sec. > Stacktrace > java.lang.NullPointerException > at org.apache.gora.store.impl.DataStoreBase.getFields(DataStoreBase.java:172) > at org.apache.gora.store.impl.DataStoreBase.getFieldsToQuery(DataStoreBase.java:168) > at org.apache.gora.memory.store.MemStore.execute(MemStore.java:148) > at org.apache.gora.query.impl.QueryBase.execute(QueryBase.java:73) > at org.apache.gora.store.DataStoreTestUtil.assertNumResults(DataStoreTestUtil.java:878) > at org.apache.gora.memory.store.MemStoreTest.testMemStoreDeleteByQueryFields(MemStoreTest.java:126) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236) > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134) > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) > Standard Output > 2015-10-05 21:09:49,513 INFO [main] store.DataStoreTestBase (DataStoreTestBase.java:setUp(90)) - setting up test > 2015-10-05 21:09:49,761 INFO [main] examples.WebPageDataCreator (WebPageDataCreator.java:createWebPageData(116)) - creating web page data > 2015-10-05 21:09:49,802 INFO [main] examples.WebPageDataCreator (WebPageDataCreator.java:createWebPageData(140)) - finished creating web page data > 2015-10-05 21:09:49,805 INFO [main] store.DataStoreTestBase (DataStoreTestBase.java:tearDown(106)) - tearing down test > {code} > and > {code} > Failed > org.apache.gora.memory.store.MemStoreTest.testGetWithFields > Failing for the past 1 build (Since Failed#1618 ) > Took 5 ms. > Error Message > expected: but was: > Stacktrace > java.lang.AssertionError: expected: but was: > at org.junit.Assert.fail(Assert.java:93) > at org.junit.Assert.failNotEquals(Assert.java:647) > at org.junit.Assert.assertEquals(Assert.java:128) > at org.junit.Assert.assertEquals(Assert.java:147) > at org.apache.gora.store.DataStoreTestUtil.assertEqualEmployeeObjects(DataStoreTestUtil.java:304) > at org.apache.gora.store.DataStoreTestUtil.testGetEmployeeWithFields(DataStoreTestUtil.java:278) > at org.apache.gora.store.DataStoreTestBase.testGetWithFields(DataStoreTestBase.java:282) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20) > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263) > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68) > at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47) > at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231) > at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60) > at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229) > at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50) > at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222) > at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28) > at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:30) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236) > at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134) > at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:606) > at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) > at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) > Standard Output > 2015-10-05 21:09:49,900 INFO [main] store.DataStoreTestBase (DataStoreTestBase.java:setUp(90)) - setting up test > 2015-10-05 21:09:49,902 INFO [main] store.DataStoreTestBase (DataStoreTestBase.java:testGetWithFields(281)) - test method: testGetWithFields > 2015-10-05 21:09:49,904 INFO [main] store.DataStoreTestBase (DataStoreTestBase.java:tearDown(106)) - tearing down test > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)