gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From emopers <...@git.apache.org>
Subject [GitHub] gora pull request: GORA-467 Flushing DataOutputStream before calli...
Date Thu, 04 Feb 2016 07:30:46 GMT
GitHub user emopers opened a pull request:


    GORA-467 Flushing DataOutputStream before calling toByteArray on the underlying ByteArrayOutputStreamFlushing
DataOutputStream before calling toByteArray on the underlying ByteArrayOutputStream

    When a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance,
    it is recommended to flush or close the DataOutputStream before invoking the underlying
instances's toByteArray(). Also, it is a good practice to call flush/close explicitly as mentioned
for example [here](http://stackoverflow.com/questions/2984538/how-to-use-bytearrayoutputstream-and-dataoutputstream-simultaneously-java).
    This pull request add a flush method before toByteArray. I have also added a [Jira Issue](https://issues.apache.org/jira/browse/GORA-467).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/emopers/gora baos_56

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
commit 4858c3b3073e664ca79c459393d39b6997549103
Author: emopers <emopers@gmail.com>
Date:   2016-02-04T07:20:31Z

    Fixing Usage of DataOutputStream


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message