gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-461) Ineffective null check in HBaseStore#getPartitions
Date Tue, 19 Jan 2016 06:16:39 GMT

    [ https://issues.apache.org/jira/browse/GORA-461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106307#comment-15106307
] 

ASF GitHub Bot commented on GORA-461:
-------------------------------------

Github user hsaputra commented on the pull request:

    https://github.com/apache/gora/pull/54#issuecomment-172752508
  
    +1


> Ineffective null check in HBaseStore#getPartitions
> --------------------------------------------------
>
>                 Key: GORA-461
>                 URL: https://issues.apache.org/jira/browse/GORA-461
>             Project: Apache Gora
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     Pair<byte[][], byte[][]> keys = table.getStartEndKeys();
>     if (keys == null || keys.getFirst() == null ||
>         keys.getFirst().length == 0) {
>       throw new IOException("Expecting at least one region.");
>     }
>     if (table == null) {
>       throw new IOException("No table was provided.");
> {code}
> The null check is ineffective since table has been de-referenced before the check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message