gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Furkan KAMACI (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-439) Remove Unused Method Parameters
Date Thu, 10 Sep 2015 22:33:46 GMT

    [ https://issues.apache.org/jira/browse/GORA-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739749#comment-14739749
] 

Furkan KAMACI commented on GORA-439:
------------------------------------

Unused method parameters may lead a potential bug. Please check below methods and comment
if there were any bugs related to any of them or they were just unused method parameters:

* CassandraSuperColumn.java#getUnionIndex(String fieldName, HColumn<ByteBuffer, ByteBuffer>
uc)

* QueryCounter.java#createJob(DataStore<K,T> dataStore, Query<K,T> query)

* QueryCounter.java#countQuery(DataStore<K,T> dataStore, Query<K,T> query)

* WordCount.java#createJob(DataStore<String,WebPage> inStore, Query<String,WebPage>
query, DataStore<String,TokenDatum> outStore)

* GoraInputFormat.java#setInputPath(PartitionQuery<K,T> partitionQuery, TaskAttemptContext
context)

* GoraInputFormat.java#setInput(Job job, Query<K1,V1> query, DataStore<K1,V1>
dataStore, boolean reuseObjects)

* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query, DataStore<K1,V1>
dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass, Class<V2> outValueClass,
 Class<? extends GoraMapper> mapperClass, Class<? extends Partitioner> partitionerClass,
boolean reuseObjects)

* GoraMapper.java#initMapperJob(Job job, Query<K1,V1> query, DataStore<K1,V1>
dataStore, Class<K2> outKeyClass, Class<K2> outKeyClass, Class<V2> outValueClass,
 Class<? extends GoraMapper> mapperClass, boolean reuseObjects)

* IOUtils.java#serialize(OutputStream os, SpecificDatumWriter<T> datumWriter, Schema
schema, T object)

* IOUtils.java#serialize(SpecificDatumWriter<T> datumWriter, Schema schema, T object)

* IOUtils.java#deserialize(InputStream is, SpecificDatumReader<T> datumReader, Schema
schema, T object)

* IOUtils.java#deserialize(byte[] bytes, SpecificDatumReader<T> datumReader, Schema
schema, T object)

* DataStoreTestUtil.java#createEmployee(DataStore<K, Employee> dataStore)

* DataStoreTestUtil.java#createWebPage(DataStore<K, Employee> dataStore)

* DataStoreTestUtil.java#createBoss(DataStore<K, Employee> dataStore)

* MongoMapping.java#addClassField(String docNameFromMapping, String classFieldName, String
docFieldName, String fieldType)

> Remove Unused Method Parameters
> -------------------------------
>
>                 Key: GORA-439
>                 URL: https://issues.apache.org/jira/browse/GORA-439
>             Project: Apache Gora
>          Issue Type: Improvement
>            Reporter: Furkan KAMACI
>            Priority: Minor
>             Fix For: 0.7
>
>
> Remove unused method parameters and make API signatures clean.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message