gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lewis John McGibbney (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-389) MongoStore: Document or List mapping change cause NPE in clearDirty()
Date Tue, 21 Oct 2014 17:17:34 GMT

    [ https://issues.apache.org/jira/browse/GORA-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14178655#comment-14178655
] 

Lewis John McGibbney commented on GORA-389:
-------------------------------------------

A MongoStore specific test would be excellent here. I've also dealt with problems like this
(schema evolution :) ) and NPE are no fun at all. 
+1 from me.

> MongoStore: Document or List mapping change cause NPE in clearDirty()
> ---------------------------------------------------------------------
>
>                 Key: GORA-389
>                 URL: https://issues.apache.org/jira/browse/GORA-389
>             Project: Apache Gora
>          Issue Type: Bug
>          Components: gora-mongodb
>    Affects Versions: 0.5
>            Reporter: Damien Raude-Morvan
>
> I've found an issue in current implementation of MongoStore on [Document or List|http://gora.apache.org/current/gora-mongodb.html]
mapping type handling.
> If your schema contains a field like this :
> {noformat}
> { "name": "keywords",
>    "type": { "type": "array", "items": "string"},
>    "default": null
> }
> {noformat}
> If you choose to latter defaults to an empty array instead of null value like this
> {noformat}
> { "name": "keywords",
>    "type": { "type": "array", "items": "string"},
>    "default": []
> }
> {noformat}
> loading old data will fail because of clearDirty method will try to also clear a null
object.
> {code}
> persistent.clearDirty();
> {code}
> I implemented and tested a fix which always return a DirtyListWrapper or DirtyMapWrapper
instead of previous null value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message