Return-Path: X-Original-To: apmail-gora-dev-archive@www.apache.org Delivered-To: apmail-gora-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 34BF911902 for ; Sun, 7 Sep 2014 22:53:29 +0000 (UTC) Received: (qmail 88323 invoked by uid 500); 7 Sep 2014 22:53:29 -0000 Delivered-To: apmail-gora-dev-archive@gora.apache.org Received: (qmail 88272 invoked by uid 500); 7 Sep 2014 22:53:29 -0000 Mailing-List: contact dev-help@gora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gora.apache.org Delivered-To: mailing list dev@gora.apache.org Received: (qmail 88259 invoked by uid 99); 7 Sep 2014 22:53:29 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 07 Sep 2014 22:53:29 +0000 Date: Sun, 7 Sep 2014 22:53:29 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@gora.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GORA-346) Create shim layer to support multiple hadoop versions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/GORA-346?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D141250= 82#comment-14125082 ]=20 ASF GitHub Bot commented on GORA-346: ------------------------------------- GitHub user lewismc opened a pull request: https://github.com/apache/gora/pull/6 GORA-346 Create shim layer to support multiple hadoop versions Hi Folks, OK so this PR rebases this patch against master branch. The only issues I have are as following =20 * ALL new modules within the Hadoop Shims patch are packaged as bundle= ... is this OK? * I do not understand the comment by Henry regarding "2. Make hadoop = shim instance to be final in the Hadoop util." If we can clarify this then = I can add to the PR and we can commit. Thank you Lewis You can merge this pull request into a Git repository by running: $ git pull https://github.com/lewismc/gora GORA-346 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/gora/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 =20 ---- commit b51cdeeadc1e79474acd250e51a77645ad676ce6 Author: Lewis John McGibbney Date: 2014-09-07T22:49:09Z GORA-346 Create shim layer to support multiple hadoop versions ---- > Create shim layer to support multiple hadoop versions > ----------------------------------------------------- > > Key: GORA-346 > URL: https://issues.apache.org/jira/browse/GORA-346 > Project: Apache Gora > Issue Type: Improvement > Affects Versions: 0.5 > Reporter: Renato Javier Marroqu=C3=ADn Mogrovejo > Assignee: Moritz Hoffmann > Labels: patch > Fix For: 0.5 > > Attachments: GORA-345_MUNGE_v1.patch, GORA-346_v1.patch, GORA-346= _v2.patch, GORA-346_v3.patch, GORA-346_v4_profiles.patch, GORA-346_v5.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)