gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keith Turner (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GORA-66) testDeleteByQueryFields seems incorrect
Date Tue, 10 Jan 2012 16:13:40 GMT

    [ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183353#comment-13183353
] 

Keith Turner commented on GORA-66:
----------------------------------

Are you asking about changing the '>=' to a '>' ?

I think the test was checking that everything greater than or equal to the end key was not
deleted.  However if the end key is inclusive, then this check is wrong.  It should ensure
that everything greater than the end key was not deleted.   I think the the following should
be true after a delete by query, this is the change in the patch.

Every row r such that r >= startKey AND r <= endKey was deleted.
Every row r such that r < startKey OR r > endKey was not deleted.
                
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Gora
>          Issue Type: Bug
>            Reporter: Keith Turner
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the existing test
against it.  It seems that the test DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is needed for
accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  As far as
I can tell the end key in a query should be inclusive, but the test treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message