gora-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julien Nioche <lists.digitalpeb...@gmail.com>
Subject Re: [VOTE] Apache Gora 0.1-incubating release (rc2)
Date Fri, 04 Mar 2011 11:14:07 GMT
Hi Tom

On 3 March 2011 23:59, Tom White <tom@cloudera.com> wrote:

> Checksums and signatures verified OK. I ran RAT and discovered that
> there are missing license headers in examples and the tutorial:
>
> Unapproved licenses:
>
>  ./CHANGES.txt
>  ./gora-core/src/examples/avro/employee.json
>  ./gora-core/src/examples/avro/tokendatum.json
>  ./gora-core/src/examples/avro/webpage.json
>
>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/Employee.java
>
>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/Metadata.java
>
>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/TokenDatum.java
>
>  ./gora-core/src/examples/java/org/apache/gora/examples/generated/WebPage.java
>  ./gora-core/src/test/conf/core-site.xml
>  ./gora-tutorial/src/main/avro/metricdatum.json
>  ./gora-tutorial/src/main/avro/pageview.json
>
>  ./gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/MetricDatum.java
>
>  ./gora-tutorial/src/main/java/org/apache/gora/tutorial/log/generated/Pageview.java
>
> You probably want to ignore the json files since there is no simple
> way of adding comments to them. The other files should have the
> license headers added though.
>

The Java pages you mentioned are all dynamically generated from the json
schemas. I will patch GoraCompiler so that it adds the headers to the java
files.


>
> I also had problems getting the build to work, but perhaps I'm doing
> something wrong here?
>
> $ ant publish-all
>
> ...
>
> BUILD FAILED
> /private/tmp/apache-gora-0.1-incubating-src/build.xml:284: The
> following error occurred while executing this line:
> /private/tmp/apache-gora-0.1-incubating-src/build-common.xml:424:
> impossible to publish artifacts for
> org.apache.gora#gora-core;working@Clouderas-MacBook-Pro-2.local:
> java.io.IOException: missing artifact
> org.apache.gora#gora-core;0.1-incubating!gora-core.jar
>


I can reproduce the issue. Not clear what 'publish-all' was meant to do in
the first place. Publish to the 'shared' repository?

The default task 'ant compile' works fine, as well as 'ant jar' which builds
on it but 'ant package'  breaks as it expects the docs to have been built.
The problem is that the task 'docs' tries to build the docs for the website
as well as the javadoc and requires forrest to be installed etc... I suggest
that we build the javadoc only as part of 'package' and handle the website
content separately, possibly via svnpubsub and a separate SVN branch.

I added javadoc as a dependency of 'package' and it now runs fine and so
does 'ant tar'

Thanks

Julien
-- 
*
*Open Source Solutions for Text Engineering

http://digitalpebble.blogspot.com/
http://www.digitalpebble.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message