Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 49E6C2009E2 for ; Wed, 1 Jun 2016 21:53:31 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 485EB160A4C; Wed, 1 Jun 2016 19:53:31 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 197E6160A45 for ; Wed, 1 Jun 2016 21:53:29 +0200 (CEST) Received: (qmail 64807 invoked by uid 500); 1 Jun 2016 19:53:29 -0000 Mailing-List: contact commits-help@gora.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@gora.apache.org Delivered-To: mailing list commits@gora.apache.org Received: (qmail 64797 invoked by uid 99); 1 Jun 2016 19:53:29 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2016 19:53:29 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 219BDE0498; Wed, 1 Jun 2016 19:53:29 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: lewismc@apache.org To: commits@gora.apache.org Message-Id: <4430efa579e04d078c2756f41f8b9b30@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: gora git commit: GORA-479 Various compilation errors in gora-infinispan module Date: Wed, 1 Jun 2016 19:53:29 +0000 (UTC) archived-at: Wed, 01 Jun 2016 19:53:31 -0000 Repository: gora Updated Branches: refs/heads/master 73250856a -> e8ed25deb GORA-479 Various compilation errors in gora-infinispan module Project: http://git-wip-us.apache.org/repos/asf/gora/repo Commit: http://git-wip-us.apache.org/repos/asf/gora/commit/e8ed25de Tree: http://git-wip-us.apache.org/repos/asf/gora/tree/e8ed25de Diff: http://git-wip-us.apache.org/repos/asf/gora/diff/e8ed25de Branch: refs/heads/master Commit: e8ed25deb75b4e9506bc6ac6121d4e7e7e5feaf6 Parents: 7325085 Author: Lewis John McGibbney Authored: Wed Jun 1 10:13:55 2016 -0700 Committer: Lewis John McGibbney Committed: Wed Jun 1 10:13:55 2016 -0700 ---------------------------------------------------------------------- .../org/apache/gora/hbase/store/HBaseStore.java | 5 +- gora-infinispan/pom.xml | 35 +- .../gora/infinispan/store/InfinispanClient.java | 2 +- .../gora/infinispan/store/InfinispanStore.java | 479 ++++++++++--------- 4 files changed, 275 insertions(+), 246 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/gora/blob/e8ed25de/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java ---------------------------------------------------------------------- diff --git a/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java b/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java index 0e07e15..00fe60b 100644 --- a/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java +++ b/gora-hbase/src/main/java/org/apache/gora/hbase/store/HBaseStore.java @@ -100,7 +100,10 @@ implements Configurable { private int scannerCaching = SCANNER_CACHING_PROPERTIES_DEFAULT ; - public HBaseStore() { + /** + * Default constructor + */ + public HBaseStore() {//Empty Constrctor } @Override http://git-wip-us.apache.org/repos/asf/gora/blob/e8ed25de/gora-infinispan/pom.xml ---------------------------------------------------------------------- diff --git a/gora-infinispan/pom.xml b/gora-infinispan/pom.xml index a8307a3..f101f76 100644 --- a/gora-infinispan/pom.xml +++ b/gora-infinispan/pom.xml @@ -29,15 +29,27 @@ Apache Gora :: Infinispan http://gora.apache.org - - The Apache Gora open source framework provides an in-memory data model and - persistence for big data. Gora supports persisting to column stores, key value stores, - document stores and RDBMSs, and analyzing the data with extensive Apache Hadoop MapReduce - support. This module provides a Gora support for the Infinispan storage system. - - 2015 + The Apache Gora open source framework provides an in-memory data model and + persistence for big data. Gora supports persisting to column stores, key value stores, + document stores and RDBMSs, and analyzing the data with extensive Apache Hadoop MapReduce + support. + 2010 + + The Apache Software Foundation + http://www.apache.org/ + + + JIRA + https://issues.apache.org/jira/browse/GORA + + + Jenkins + https://builds.apache.org/job/Gora-trunk/ + + * + org.apache.gora.infinispan*;version="${project.version}";-noimport:=true 7.2.5.Final 1.0 1.0.Final @@ -109,6 +121,15 @@ org.apache.gora gora-core + compile + + + + + org.apache.hadoop + hadoop-client + compile + true http://git-wip-us.apache.org/repos/asf/gora/blob/e8ed25de/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java ---------------------------------------------------------------------- diff --git a/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java b/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java index ccd45e3..ab0a64b 100644 --- a/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java +++ b/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanClient.java @@ -75,7 +75,7 @@ public class InfinispanClient implements Configurab properties.setProperty(ISPN_CONNECTION_STRING_KEY, host); LOG.info("Connecting client to "+host); - Marshaller marshaller = new Marshaller(persistentClass); + Marshaller marshaller = new Marshaller<>(persistentClass); ConfigurationBuilder builder = new ConfigurationBuilder(); builder.addServers(host); builder.marshaller(marshaller); http://git-wip-us.apache.org/repos/asf/gora/blob/e8ed25de/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java ---------------------------------------------------------------------- diff --git a/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java b/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java index 488e477..cb198ff 100644 --- a/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java +++ b/gora-infinispan/src/main/java/org/apache/gora/infinispan/store/InfinispanStore.java @@ -47,251 +47,256 @@ import static org.apache.gora.mapreduce.GoraRecordReader.BUFFER_LIMIT_READ_VALUE */ public class InfinispanStore extends DataStoreBase { - public static final Logger LOG = LoggerFactory.getLogger(InfinispanStore.class); + public static final Logger LOG = LoggerFactory.getLogger(InfinispanStore.class); - private InfinispanClient infinispanClient; - private String primaryFieldName; - private int primaryFieldPos; - private int splitSize; + private InfinispanClient infinispanClient; + private String primaryFieldName; + private int primaryFieldPos; + private int splitSize; - public InfinispanStore() throws Exception {} + /** + * Default constructor + */ + public InfinispanStore(){ + //Empty default constructor + } - @Override - public synchronized void initialize(Class keyClass, Class persistentClass, Properties properties) { + @Override + public synchronized void initialize(Class keyClass, Class persistentClass, Properties properties) { - try { + try { - if (primaryFieldName!=null) { - LOG.info("Client already initialized; ignoring."); - return; - } - - super.initialize(keyClass, persistentClass, properties); - infinispanClient = new InfinispanClient<>(); - infinispanClient.setConf(conf); - - LOG.info("key class: " - + keyClass.getCanonicalName() - + ", persistent class: " - + persistentClass.getCanonicalName()); - schema = persistentClass.newInstance().getSchema(); - - splitSize = Integer.valueOf( - properties.getProperty( BUFFER_LIMIT_READ_NAME, - getConf().get( - BUFFER_LIMIT_READ_NAME, - Integer.toString(BUFFER_LIMIT_READ_VALUE)))); - LOG.info("split size: "+splitSize); - - primaryFieldPos = 0; - primaryFieldName = schema.getFields().get(0).name(); - this.infinispanClient.initialize(keyClass, persistentClass, properties); - - } catch (Exception e) { - throw new RuntimeException(e); + if (primaryFieldName!=null) { + LOG.info("Client already initialized; ignoring."); + return; } - } - - @Override - public void close() { - LOG.debug("close()"); - infinispanClient.close(); - } - - @Override - public void createSchema() { - LOG.debug("createSchema()"); - this.infinispanClient.createCache(); - } - - @Override - public boolean delete(K key) { - LOG.debug("delete(" + key+")"); - this.infinispanClient.deleteByKey(key); - return true; - } - - @Override - public long deleteByQuery(Query query) { - ((InfinispanQuery) query).build(); - LOG.debug("deleteByQuery("+query.toString()+")"); - InfinispanQuery q = (InfinispanQuery) query; - q.build(); - for( T t : q.list()){ - infinispanClient.deleteByKey((K) t.get(primaryFieldPos)); - } - return q.getResultSize(); - } - - @Override - public void deleteSchema() { - LOG.debug("deleteSchema()"); - this.infinispanClient.dropCache(); - } - - @Override - public Result execute(Query query) { - LOG.debug("execute()"); - ((InfinispanQuery)query).build(); - InfinispanResult result = new InfinispanResult<>(this, (InfinispanQuery)query); - LOG.trace("query: " + query.toString()); - LOG.trace("result size: " + result.size()); - return result; - } - - @Override - public T get(K key){ - LOG.debug("get("+key+")"); + + super.initialize(keyClass, persistentClass, properties); + infinispanClient = new InfinispanClient<>(); + infinispanClient.setConf(conf); + + LOG.info("key class: " + + keyClass.getCanonicalName() + + ", persistent class: " + + persistentClass.getCanonicalName()); + schema = persistentClass.newInstance().getSchema(); + + splitSize = Integer.valueOf( + properties.getProperty( BUFFER_LIMIT_READ_NAME, + getConf().get( + BUFFER_LIMIT_READ_NAME, + Integer.toString(BUFFER_LIMIT_READ_VALUE)))); + LOG.info("split size: "+splitSize); + + primaryFieldPos = 0; + primaryFieldName = schema.getFields().get(0).name(); + this.infinispanClient.initialize(keyClass, persistentClass, properties); + + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + @Override + public void close() { + LOG.debug("close()"); + infinispanClient.close(); + } + + @Override + public void createSchema() { + LOG.debug("createSchema()"); + this.infinispanClient.createCache(); + } + + @Override + public boolean delete(K key) { + LOG.debug("delete(" + key+")"); + this.infinispanClient.deleteByKey(key); + return true; + } + + @Override + public long deleteByQuery(Query query) { + ((InfinispanQuery) query).build(); + LOG.debug("deleteByQuery("+query.toString()+")"); + InfinispanQuery q = (InfinispanQuery) query; + q.build(); + for( T t : q.list()){ + infinispanClient.deleteByKey((K) t.get(primaryFieldPos)); + } + return q.getResultSize(); + } + + @Override + public void deleteSchema() { + LOG.debug("deleteSchema()"); + this.infinispanClient.dropCache(); + } + + @Override + public Result execute(Query query) { + LOG.debug("execute()"); + ((InfinispanQuery)query).build(); + InfinispanResult result = new InfinispanResult<>(this, (InfinispanQuery)query); + LOG.trace("query: " + query.toString()); + LOG.trace("result size: " + result.size()); + return result; + } + + @Override + public T get(K key){ + LOG.debug("get("+key+")"); + return infinispanClient.get(key); + } + + @Override + public T get(K key, String[] fields) { + LOG.debug("get("+key+","+fields+")"); + if (fields==null) return infinispanClient.get(key); - } - - @Override - public T get(K key, String[] fields) { - LOG.debug("get("+key+","+fields+")"); - if (fields==null) - return infinispanClient.get(key); - - InfinispanQuery query = new InfinispanQuery(this); - query.setKey(key); - query.setFields(fields); - query.build(); - - - Result result = query.execute(); - try { - result.next(); - return result.get(); - } catch (Exception e) { - throw new RuntimeException(e); - } - } - - /** - * - * Split the query per infinispan node resulting in a list of queries. - * For each Infinispan server, this function returns a set of qeuries - * using pagination of the originial query. The size of each query - * in this pagination equals gora.buffer.read.limit. - * - * @param query the base query to create the partitions for. If the query - * is null, then the data store returns the partitions for the default query - * (returning every object) - * @return - * @throws IOException - */ - @Override - public List> getPartitions(Query query) - throws IOException { - LOG.debug("getPartitions()"); - - // 1 - split the query per location - List> locations = ((InfinispanQuery)query).split(); - - // 2 -split each location - List> splitLocations = new ArrayList<>(); - for(PartitionQuery location : locations) { - - LOG.trace("location: "+ ((InfinispanQuery)location).getLocation().toString()); - - // 2.1 - compute the result size - InfinispanQuery sizeQuery = (InfinispanQuery) ((InfinispanQuery) location).clone(); - sizeQuery.setFields(primaryFieldName); - sizeQuery.setLimit(1); - sizeQuery.rebuild(); - - // 2.2 - check if splitting is necessary - int resultSize = sizeQuery.getResultSize(); - long queryLimit = query.getLimit(); - long splitLimit = queryLimit>0 ? Math.min((long)resultSize,queryLimit) : resultSize; - LOG.trace("split limit: "+ splitLimit); - LOG.trace("split size: "+ splitSize); - if (splitLimit <= splitSize) { - LOG.trace("location returned"); - splitLocations.add(location); - continue; - } - - // 2.3 - compute the splits - for(int i=0; i split = (InfinispanQuery) ((InfinispanQuery) location).clone(); - split.setOffset(i * splitSize); - split.setLimit(splitSize); - split.rebuild(); - splitLocations.add(split); - } + + InfinispanQuery query = new InfinispanQuery(this); + query.setKey(key); + query.setFields(fields); + query.build(); + + + Result result = query.execute(); + try { + result.next(); + return result.get(); + } catch (Exception e) { + throw new RuntimeException(e); + } + } + + /** + * + * Split the query per infinispan node resulting in a list of queries. + * For each Infinispan server, this function returns a set of qeuries + * using pagination of the originial query. The size of each query + * in this pagination equals gora.buffer.read.limit. + * + * @param query the base query to create the partitions for. If the query + * is null, then the data store returns the partitions for the default query + * (returning every object) + * @return + * @throws IOException + */ + @Override + public List> getPartitions(Query query) + throws IOException { + LOG.debug("getPartitions()"); + + // 1 - split the query per location + List> locations = ((InfinispanQuery)query).split(); + + // 2 -split each location + List> splitLocations = new ArrayList<>(); + for(PartitionQuery location : locations) { + + LOG.trace("location: "+ ((InfinispanQuery)location).getLocation().toString()); + + // 2.1 - compute the result size + InfinispanQuery sizeQuery = (InfinispanQuery) ((InfinispanQuery) location).clone(); + sizeQuery.setFields(primaryFieldName); + sizeQuery.setLimit(1); + sizeQuery.rebuild(); + + // 2.2 - check if splitting is necessary + int resultSize = sizeQuery.getResultSize(); + long queryLimit = query.getLimit(); + long splitLimit = queryLimit>0 ? Math.min((long)resultSize,queryLimit) : resultSize; + LOG.trace("split limit: "+ splitLimit); + LOG.trace("split size: "+ splitSize); + if (splitLimit <= splitSize) { + LOG.trace("location returned"); + splitLocations.add(location); + continue; } - return splitLocations; - } - - @Override - public void flush() { - LOG.debug("flush()"); - infinispanClient.flush(); - } - - /** - * In Infinispan, Schemas are referred to as caches. - * - * @return Cache - */ - @Override - public String getSchemaName() { - LOG.debug("getSchemaName()"); - return this.infinispanClient.getCacheName(); - } - - @Override - public Query newQuery() { - LOG.debug("newQuery()"); - Query query = new InfinispanQuery(this); - query.setFields(getFieldsToQuery(null)); - return query; - } - - @Override - public void put(K key, T obj) { - LOG.debug("put(" +key.toString()+")"); - LOG.trace(obj.toString()); - - if (obj.get(primaryFieldPos)==null) - obj.put(primaryFieldPos,key); - - if (!obj.get(primaryFieldPos).equals(key) ) - LOG.warn("Invalid or different primary field :"+key+"<->"+obj.get(primaryFieldPos)); - - this.infinispanClient.put(key, obj); - } - - @Override - public boolean schemaExists() { - LOG.debug("schemaExists()"); - return infinispanClient.cacheExists(); - } - - public InfinispanClient getClient() { - LOG.debug("getClient()"); - return infinispanClient; - } - - public String getPrimaryFieldName() { - LOG.debug("getPrimaryField()"); - return primaryFieldName; - } - - public void setPrimaryFieldName(String name){ - LOG.debug("getPrimaryFieldName()"); - primaryFieldName = name; - } - - public int getPrimaryFieldPos(){ - LOG.debug("getPrimaryFieldPos()"); - return primaryFieldPos; - } - - public void setPrimaryFieldPos(int p){ - LOG.debug("setPrimaryFieldPos()"); - primaryFieldPos = p; - } + // 2.3 - compute the splits + for(int i=0; i split = (InfinispanQuery) ((InfinispanQuery) location).clone(); + split.setOffset(i * splitSize); + split.setLimit(splitSize); + split.rebuild(); + splitLocations.add(split); + } + } + + return splitLocations; + } + + @Override + public void flush() { + LOG.debug("flush()"); + infinispanClient.flush(); + } + + /** + * In Infinispan, Schemas are referred to as caches. + * + * @return Cache + */ + @Override + public String getSchemaName() { + LOG.debug("getSchemaName()"); + return this.infinispanClient.getCacheName(); + } + + @Override + public Query newQuery() { + LOG.debug("newQuery()"); + Query query = new InfinispanQuery<>(this); + query.setFields(getFieldsToQuery(null)); + return query; + } + + @Override + public void put(K key, T obj) { + LOG.debug("put(" +key.toString()+")"); + LOG.trace(obj.toString()); + + if (obj.get(primaryFieldPos)==null) + obj.put(primaryFieldPos,key); + + if (!obj.get(primaryFieldPos).equals(key) ) + LOG.warn("Invalid or different primary field :"+key+"<->"+obj.get(primaryFieldPos)); + + this.infinispanClient.put(key, obj); + } + + @Override + public boolean schemaExists() { + LOG.debug("schemaExists()"); + return infinispanClient.cacheExists(); + } + + public InfinispanClient getClient() { + LOG.debug("getClient()"); + return infinispanClient; + } + + public String getPrimaryFieldName() { + LOG.debug("getPrimaryField()"); + return primaryFieldName; + } + + public void setPrimaryFieldName(String name){ + LOG.debug("getPrimaryFieldName()"); + primaryFieldName = name; + } + + public int getPrimaryFieldPos(){ + LOG.debug("getPrimaryFieldPos()"); + return primaryFieldPos; + } + + public void setPrimaryFieldPos(int p){ + LOG.debug("setPrimaryFieldPos()"); + primaryFieldPos = p; + } }